| Summary: | [BYT/BSW Bisected] Suspend Resume time increase by 10 times longer | ||
|---|---|---|---|
| Product: | DRI | Reporter: | wendy.wang |
| Component: | DRM/Intel | Assignee: | Maarten Lankhorst <bugs> |
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Severity: | critical | ||
| Priority: | highest | CC: | intel-gfx-bugs |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | |||
|
Description
wendy.wang
2015-06-05 08:51:19 UTC
Created attachment 116316 [details]
manually responsiveness script
Could you remove the line: "intel_display_set_init_power(dev_priv, false);" from intel_display.c ? Does that fix this issue? (In reply to Maarten Lankhorst from comment #2) > Could you remove the line: > "intel_display_set_init_power(dev_priv, false);" > > from intel_display.c ? Does that fix this issue? Remove "intel_display_set_init_power(dev_priv, false);", Suspend resume time still very large: 7000+ ms on baytray platform. Created attachment 116343 [details]
dmesg_remove_intel_display_set_init_power_on_byt01
Could you boot with log_buf_len=4M drm.debug=0x1f ? Created attachment 116348 [details]
dmesg with log_buf_len=4M drm.debug=0x1f
First issue seems to be dpll failing to lock. Could you get me 2 dmesg logs with log_buf_len=4M drm.debug=0x1f? First one on commit 490f400db5d886fc28566af69b02f6497f31be4b, the other one before it? Created attachment 116379 [details]
dmesg info of the commit 490f400d bad
Created attachment 116380 [details]
dmesg info of the commit 7f0724 good
Ah thanks, that's useful. Doing some analysis on the diff: intel_display_power_put is called on more domains on the good commit. This points to a possible bug in power domains. For the primary plane src and dst seems to indicate why planes stay hidden: -[drm:intel_dump_pipe_config] scaler:0 src (0, 0) 0x0 dst (0, 0) 0x0 +[drm:intel_dump_pipe_config] scaler:0 src (0, 0) 1920x1080 dst (0, 0) 1920x1080 This shows a bug caused by not having support for atomic planes, it's fixed by convert to atomic, part 3. I also see the following, more worrying error: -[drm:vlv_enable_pll [i915]] *ERROR* DPLL 0 failed to lock Just in case I already fixed it, could you test with http://cgit.freedesktop.org/~mlankhorst/linux/log/?h=unify-flip-modeset ? If it doesn't fit it, post a log with drm.debug=0x1f on that branch please. Created attachment 116417 [details]
BYT Platform_dmesg_unify-flip-modeset _branch_i915_responsiveness_testing
(In reply to Maarten Lankhorst from comment #10) > Ah thanks, that's useful. > > Doing some analysis on the diff: > > intel_display_power_put is called on more domains on the good commit. > This points to a possible bug in power domains. > > For the primary plane src and dst seems to indicate why planes stay hidden: > -[drm:intel_dump_pipe_config] scaler:0 src (0, 0) 0x0 dst (0, 0) 0x0 > +[drm:intel_dump_pipe_config] scaler:0 src (0, 0) 1920x1080 dst (0, 0) > 1920x1080 > > This shows a bug caused by not having support for atomic planes, it's fixed > by convert to atomic, part 3. > > I also see the following, more worrying error: > -[drm:vlv_enable_pll [i915]] *ERROR* DPLL 0 failed to lock > > Just in case I already fixed it, could you test with > > http://cgit.freedesktop.org/~mlankhorst/linux/log/?h=unify-flip-modeset ? > > If it doesn't fit it, post a log with drm.debug=0x1f on that branch please. We tested unify-flip-modeset branch on BYT platform, result show the regression failure has been fixed, but we see the suspend resume time still be a little big: 900 ms,do you have any idea to improve it? Thanks. init time=106.271 ms suspend time =374.996 ms suspend resume time=904.815 ms Should be fixed by commit aee5624f3158be1aecd808351607d7a6ded09643 Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Date: Wed Jun 10 10:24:19 2015 +0200 Revert "drm/i915: Make intel_display_suspend atomic, v2." commit f662af8c5c1619b91e3834fff103e7423e20df81 Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Date: Wed Jun 10 10:24:20 2015 +0200 Revert "drm/i915: Read hw state into an atomic state struct, v2." please retest current drm-intel-nightly. (In reply to Jani Nikula from comment #13) > Should be fixed by > > commit aee5624f3158be1aecd808351607d7a6ded09643 > Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Date: Wed Jun 10 10:24:19 2015 +0200 > > Revert "drm/i915: Make intel_display_suspend atomic, v2." > > commit f662af8c5c1619b91e3834fff103e7423e20df81 > Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Date: Wed Jun 10 10:24:20 2015 +0200 > > Revert "drm/i915: Read hw state into an atomic state struct, v2." > > please retest current drm-intel-nightly. Hello Jani, We cannot verify latest drm-intel-nightly kernel, as there is a block issue after do the patches revert: 90929 - [BYT/BDW/BSW/SKL Bisected]system boot fail https://bugs.freedesktop.org/show_bug.cgi?id=90929 This issue can be fix test with http://cgit.freedesktop.org/~mlankhorst/linux/log/?h=topic/bug-90929 https://bugs.freedesktop.org/show_bug.cgi?id=90929 So we are waiting for bug 90929 fix patch merge up. Verified latest drm-intel-nightly branch kernel on BSW and BYT, this issue has been fixed, so closed. Closing old verified. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.