| Summary: | [BYT/BDW/BSW/SKL Bisected]system boot fail | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | lu hua <huax.lu> | ||||||
| Component: | DRM/Intel | Assignee: | Maarten Lankhorst <bugs> | ||||||
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||
| Severity: | blocker | ||||||||
| Priority: | highest | CC: | intel-gfx-bugs, jani.nikula | ||||||
| Version: | unspecified | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux (All) | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
lu hua
2015-06-11 01:15:28 UTC
Bisect shows:f662af8c5c1619b91e3834fff103e7423e20df81 is the first bad commit commit f662af8c5c1619b91e3834fff103e7423e20df81 Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> AuthorDate: Wed Jun 10 10:24:20 2015 +0200 Commit: Jani Nikula <jani.nikula@intel.com> CommitDate: Wed Jun 10 14:57:40 2015 +0300 Revert "drm/i915: Read hw state into an atomic state struct, v2." This reverts commit 3bae26eb2991c00670df377cf6c3bc2b0577e82a. Seems it introduces regressions for 3 different reasons, oh boy.. In bug #90868 as I can see the atomic state will be restored on resume without the planes being set up properly. Because plane setup here requires the atomic state, we'll have to settle for committing atomic planes first. In bug #90861 the failure appears to affect mostly DP devices, and happens because reading out the atomic state prevents a modeset on boot, which would require better hw state readout. In bug #90874 it's shown that cdclk should be part of the atomic state, so only performing a single modeset during resume excarbated the issue. It's better to fix those issues first, and then commit this patch, so do that temporarily. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90868 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90861 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90874 Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Acked-by: Ander Conselvan de Oliveira <conselvan2@gmail.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> My HSW hangs on i915 load as well now. Bisected it to the same commit. Created attachment 116431 [details] [review] drm/i915: Make hw readout less atomic. Does this fix things? Maarten, please set bugs to NEEDINFO to ensure QA notices. Ok not good enough. Can you test http://cgit.freedesktop.org/~mlankhorst/linux/log/?h=topic/bug-90929 ? Should fix all. Fixed for me on BDW. Thanks. (In reply to Maarten Lankhorst from comment #5) > Ok not good enough. > > Can you test > http://cgit.freedesktop.org/~mlankhorst/linux/log/?h=topic/bug-90929 ? > Should fix all. Fixed for me on BYT/BDW/BSW/SKL/. Test it on the latest nightly kernel, this problem has go away. So verified it. Closing old verified. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.