Summary: | Add support for ResetForm action | ||
---|---|---|---|
Product: | poppler | Reporter: | Marek Kasik <mkasik> |
Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
Status: | RESOLVED MOVED | QA Contact: | |
Severity: | enhancement | ||
Priority: | medium | CC: | lgrosenthal |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
Sample form
Add ability to reset forms Add support for ResetForm action to Link class glib: Add ability to reset forms Add handling of ResetForm action 1/2 Add handling of additional actions for annotations 2/2 |
Created attachment 116515 [details] [review] Add ability to reset forms Add reset() method to FormField class and its descendants. Use DV field for resetting FormFieldText, FormFieldChoice and FormFieldButton. Add reset() also to Form class. Created attachment 116516 [details] [review] Add support for ResetForm action to Link class Add LinkResetForm class which stores information needed for resetting of fields of forms. Created attachment 116517 [details] [review] glib: Add ability to reset forms Add new PopplerActionType POPPLER_ACTION_RESET_FORM and its handling to PopplerAction. Add poppler_document_reset_form() to PopplerDocument. I've also added a related patch to https://bugs.freedesktop.org/show_bug.cgi?id=77601. It is needed in applications which would like to use the ResetForm action via glib frontend. Created attachment 116520 [details] [review] Add handling of ResetForm action 1/2 This is a preliminary version of a patch for evince which add the reset form ability to evince so you can test it. Created attachment 116521 [details] [review] Add handling of additional actions for annotations 2/2 And this is a preliminary version of a patch for evince which adds the ability to handle additional annotation actions to evince. What are the last 2 patches? Evince code? Also, have you looked at the long discussion in the mailing list we had ages ago on supporting this? Yeah, evince patches should be in gnome's bugzilla. We had some patches around from one student of mine, i don't recall where they ended. Will look for those. I haven't reviewed the patches yet, but as Albert said, we have discussed this several times in the mailing list: http://lists.freedesktop.org/archives/poppler/2010-June/005866.html http://lists.freedesktop.org/archives/poppler/2011-August/007765.html http://lists.freedesktop.org/archives/poppler/2012-March/008805.html I'll look at the patches as soon as I find some time, but please, check those discussions, to make sure all previous concerns are addressed. We already have a bug open for evince: http://bugzilla.gnome.org/show_bug.cgi?id=477841 Evince patches should be attached there. Thanks! Thank you for pointing me to the discussion, I'll read through that. I attached the evince patches to allow you to test the poppler patches. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/225. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 116513 [details] Sample form Current poppler doesn't handle ResetForm action so it is not able to reset forms.