Bug 90982

Summary: Add support for ResetForm action
Product: poppler Reporter: Marek Kasik <mkasik>
Component: generalAssignee: poppler-bugs <poppler-bugs>
Status: RESOLVED MOVED QA Contact:
Severity: enhancement    
Priority: medium CC: lgrosenthal
Version: unspecified   
Hardware: Other   
OS: All   
i915 platform: i915 features:
Attachments: Sample form
Add ability to reset forms
Add support for ResetForm action to Link class
glib: Add ability to reset forms
Add handling of ResetForm action 1/2
Add handling of additional actions for annotations 2/2

Description Marek Kasik 2015-06-15 14:35:21 UTC
Created attachment 116513 [details]
Sample form

Current poppler doesn't handle ResetForm action so it is not able to reset forms.
Comment 1 Marek Kasik 2015-06-15 14:39:42 UTC
Created attachment 116515 [details] [review]
Add ability to reset forms

Add reset() method to FormField class and its descendants. Use DV field for resetting FormFieldText, FormFieldChoice and FormFieldButton. Add reset() also to Form class.
Comment 2 Marek Kasik 2015-06-15 14:40:09 UTC
Created attachment 116516 [details] [review]
Add support for ResetForm action to Link class

Add LinkResetForm class which stores information needed for resetting of fields of forms.
Comment 3 Marek Kasik 2015-06-15 14:40:53 UTC
Created attachment 116517 [details] [review]
glib: Add ability to reset forms

Add new PopplerActionType POPPLER_ACTION_RESET_FORM and its handling to PopplerAction.
Add poppler_document_reset_form() to PopplerDocument.
Comment 4 Marek Kasik 2015-06-15 14:43:01 UTC
I've also added a related patch to https://bugs.freedesktop.org/show_bug.cgi?id=77601. It is needed in applications which would like to use the ResetForm action via glib frontend.
Comment 5 Marek Kasik 2015-06-15 14:49:23 UTC
Created attachment 116520 [details] [review]
Add handling of ResetForm action 1/2

This is a preliminary version of a patch for evince which add the reset form ability to evince so you can test it.
Comment 6 Marek Kasik 2015-06-15 14:50:42 UTC
Created attachment 116521 [details] [review]
Add handling of additional actions for annotations 2/2

And this is a preliminary version of a patch for evince which adds the ability to handle additional annotation actions to evince.
Comment 7 Albert Astals Cid 2015-06-19 19:55:15 UTC
What are the last 2 patches? Evince code?

Also, have you looked at the long discussion in the mailing list we had ages ago on supporting this?
Comment 8 Jose Aliste 2015-06-19 20:28:13 UTC
Yeah, evince patches should be in gnome's bugzilla. We had some patches around from one student of mine, i don't recall where they ended. Will look for those.
Comment 9 Carlos Garcia Campos 2015-06-20 09:35:49 UTC
I haven't reviewed the patches yet, but as Albert said, we have discussed this several times in the mailing list:


I'll look at the patches as soon as I find some time, but please, check those discussions, to make sure all previous concerns are addressed.

We already have a bug open for evince:


Evince patches should be attached there.

Comment 10 Marek Kasik 2015-06-22 08:50:02 UTC
Thank you for pointing me to the discussion, I'll read through that.
I attached the evince patches to allow you to test the poppler patches.
Comment 11 GitLab Migration User 2018-08-20 22:11:53 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/225.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.