Bug 9102

Summary: cairo doesn't support 24 bits per pixel mode on X11
Product: cairo Reporter: Erik Ohrnberger <erik>
Component: image backendAssignee: Carl Worth <cworth>
Status: RESOLVED FIXED QA Contact: cairo-bugs mailing list <cairo-bugs>
Severity: normal    
Priority: high    
Version: 1.0.4   
Hardware: x86 (IA32)   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Erik Ohrnberger 2006-11-20 20:11:02 UTC
As discussed in the mailing list:

On 11/19/06, Erik Ohrnberger <Erik@echohome.org> wrote:
> > -----Original Message-----
> > From: cairo-bounces@cairographics.org 
> > [mailto:cairo-bounces@cairographics.org] On Behalf Of Daniel Amelang
> > Sent: Sunday, November 19, 2006 11:10 PM
> > To: Vladimir Vukicevic
> > Cc: cairo@cairographics.org; Erik@echohome.org
> > Subject: Re: [cairo] cairo-xlib-surface.c:402:
> > _swap_ximage_to_native:Assertion `NOT_REACHED' failed.
> >
> > On 11/19/06, Vladimir Vukicevic <vladimir@pobox.com> wrote:
> > > ----- Daniel Amelang <daniel.amelang@gmail.com> wrote:
> > > > On 11/18/06, Erik Ohrnberger <Erik@echohome.org> wrote:
> > > > > Generally, I'm running an X Window server emulator on
> > my Windows
> > > > > PC and pipe the display up there.  The PC is set to 32
> > bit color
> > > > > depth, and when the DISLPAY env var is set to the IP of the 
> > > > > Windows PC, that is when the applications fail with this error.
> > > > >
> > > > > Is there a setting someplace on the Linux side where I
> > can force a
> > > > > similar color depth as to the Option "Pixmap" "32" you
> > mention below?
> > > > >
> > > > > Thanks for the help, I really appreciate it.
> > > >
> > > > Hmmm...your question is outside the scope of this list, as your 
> > > > problem is not cairo-related. You'll find better answers here 
> > > > (especially the cygwin-xfree part):
> > >
> > > Well, it is sort of cairo related -- these X severs /are/
> > out there (including Xvnc and various others), and having cairo 
> > assert out on them is not a good solution, IMO.
> >
> > Yea, totally agree. I was reponding to his question about cygwin/X.
> > Sorry for the confusion, I didn't mean to imply that no one is going 
> > to address the root of the problem. As I said in my first response 
> > to Erik, I think this should problem should be in bugzilla and get 
> > the proper attention.
> >
> > Dan
> >
>
> I have to admit that it's not cygwin/X, but an old program called 
> VisionWare, and has served me faithfully for a long number of years.

Ah, sorry for jumping to conclusions. Unfortunately, I have no idea how to get 
VisionWare's XVision into 32bpp mode. In fact, the following posting seems to 
say that XVision doesn't support 32bpp Pixmaps at all :(

http://www.cygwin.com/ml/cygwin-xfree/2002-04/msg00366.html

So I'm all out of ideas for workarounds. Sorry.

> Specific version information that could proove helpful:
>
> gtkmm-2.8.1, gtk+-2.6.10, cairo-0.1.6           works
> gtkmm-1.2.9-r2, gtk+-2.8.19, cairo-1.0.4        does not work

Cairo has changed so much from 0.1.6 to 1.0.4, especially in the place in xlib-
surface where the problem is. I can see the before and after code paths, but 
it doesn't help solve the problem. Thing is, libpixman in now used in places 
that previously only contained X calls. And it's pixman's lack of support for 
24bpp that is the root of the problem. At least that's my understanding.

> Should I go and put this information in bugzilla?  I'd be willing to 
> do so, but I'd have to find out where the bugzilla site is.

Here:

https://bugs.freedesktop.org/enter_bug.cgi?product=cairo

Thanks for reporting this.

Carl/whoever is listening: could a quick stopgap measure be to do a conversion 
from 24bpp to 32bpp before the image is handed over to pixman (or write a 
conversion function in pixman that cairo-xlib can call)? Ideally, one would 
want pixman to support 24bpp directly, but since that's a lot of work, and 
this isn't a common case, it might be worth considering a slow and messy 
approach. People don't call _acquire_(source|dest)_image in their display loop 
anyways, right?

Dan
_______________________________________________
cairo mailing list
cairo@cairographics.org
http://cairographics.org/cgi-bin/mailman/listinfo/cairo
Comment 1 Chris Wilson 2008-10-15 02:56:09 UTC
commit bc872a5f5fb9b6318dc78d132da46a6b201f75c7
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Oct 15 10:21:05 2008 +0100

    [xlib] Handle 4,20,24,28 depth XImages
    
    Bug 9102 cairo doesn't support 24 bits per pixel mode on X11
    (https://bugs.freedesktop.org/show_bug.cgi?id=9102)
    is a reminder that that we need to support many obscure XImage formats.
    With Carl's and Behdad's work to support psuedocolor we have a mechanism
    in place to handle any format that is not natively handled by pixman. The
    only piece we were missing was extending the swapper to handle all-known
    formats and putting in defensive checks that pixels were correctly aligned
    in accordance with pixman's requirements.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.