Bug 91191

Summary: udisks1 systemd service file has incorrect installation path substitution
Product: udisks Reporter: David King <amigadave>
Component: generalAssignee: Martin Pitt <martin.pitt>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
See Also: https://bugzilla.redhat.com/show_bug.cgi?id=1238664
Whiteboard:
i915 platform: i915 features:
Attachments: fix the substitution
corrected commit message

Description David King 2015-07-02 13:11:43 UTC
The sed snippet for substituting the systemd service file path in udisks1 is:

sed -e "s|\@libexecdir\@|$(prefix)/lib/udisks|" $< > $@

Unfortunately, udisks-daemon is installed into libexecdir, so this ends up being wrong:

https://bugzilla.redhat.com/show_bug.cgi?id=1238664
Comment 1 David King 2015-07-02 13:13:05 UTC
Created attachment 116877 [details] [review]
fix the substitution

I realise that udisks1 will probably never see any more tarball releases, but it would be good to get the fix in git.
Comment 2 David King 2015-07-02 13:14:27 UTC
Created attachment 116878 [details] [review]
corrected commit message
Comment 3 Martin Pitt 2016-02-29 16:17:37 UTC
Pushed, thanks. But right, there won't be a new udisks 1.x release.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.