Bug 91210

Summary: [SKL] igt/kms_flip/rcs-wf_vblank-vs-modeset-interruptible crash
Product: DRI Reporter: Olivier Berthier <olivierx.berthier>
Component: DRM/IntelAssignee: Jim Bish <jim.bish>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: intel-gfx-bugs
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: SKL i915 features:
Attachments:
Description Flags
Kernel.log
none
dmesg log file
none
kern_log_render-flip-vs-modeset-interruptible
none
dmesg log file with patches none

Description Olivier Berthier 2015-07-03 12:11:02 UTC 
Created attachment 116910 [details]
Kernel.log

Regression
-----------
Tested for the firt time on this test environment

Setup:
-------
Hardware
Hardware
Platform: SKY LAKE Y A0 
CPU : Intel(R) Core(TM) m3-6Y30 CPU @ 0.8GHz 4MB (family: 6, model: 78  stepping: 3)
MCP : SKL-Y  D1  2+2 (ou ULX-D1)
QDF : QYV3 
CPU : SKL D0
Chipset PCH: Sunrise Point LP C1       
CRB : SKY LAKE Y LPDDR3 RVP3 CRB FAB2
Reworks : All Mandatories + FBS02 & FBS03, O-06
Software 
Linux : Ubuntu 14.04 LTS 64 bits
BIOS : SKLSE2R1.R00.X085.B02.150601337
ME FW : 11.0.0.1149
Ksc (EC FW): 1.15
Kernel 4.1-0 from git://anongit.freedesktop.org/drm-intel tag drm-intel-nightly-2015-06-27
Mesa: mesa-10.5.8 from http://cgit.freedesktop.org/mesa/mesa/
Xf86_video_intel: 2.99.917 from http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/
Libdrm: libdrm-2.4.61 from http://cgit.freedesktop.org/mesa/drm/
Cairo: 1.14.2 from http://cgit.freedesktop.org/cairo
libva: libva-1.6.0.pre1 from http://cgit.freedesktop.org/libva/
intel-driver: 1.6.0.pre1 from http://cgit.freedesktop.org/vaapi/intel-driver
xorg: 1.17.99 installed with script git_xorg.sh
Xserver: xorg-server-1.17.2 from http://cgit.freedesktop.org/xorg/xserver
Intel-gpu-tools: intel-gpu-tools-1.11 from http://cgit.freedesktop.org/xorg/app/intel-gpu-tools/

Steps:
------
1. Launch igt with command:
<...>/scripts/run-tests.sh -t kms_flip@rcs-wf_vblank-vs-modeset-interruptible
2. The test start

Actual result:
---------------
2. DUT crash when executing kms_flip/rcs-wf_vblank-vs-modeset-interruptible

Expected result:
----------------
2. No crash

End of kern.log
----------------
Jul  2 11:44:57 SKLY6 kernel: [  448.069377] [drm:skl_disable_dc6] Disabling DC6
Jul  2 11:44:57 SKLY6 kernel: [  448.069447] [drm:skl_set_power_well] Enabling power well 2
Jul  2 11:44:57 SKLY6 kernel: [  448.069475] [drm:intel_display_power_get] enabling DDI C power well
Jul  2 11:44:57 SKLY6 kernel: [  448.069481] [drm:skl_set_power_well] Enabling DDI C power well
Jul  2 11:44:57 SKLY6 kernel: [  448.069494] [drm:intel_enable_shared_dpll] enable DPLL 1 (active 0, on? 0) for crtc 26
Jul  2 11:44:57 SKLY6 kernel: [  448.069499] [drm:intel_enable_shared_dpll] enabling DPLL 1
Jul  2 11:44:57 SKLY6 kernel: [  448.071733] [drm:skylake_pfit_update] for crtc_state = ffff88016c2adc00
Jul  2 11:44:57 SKLY6 kernel: [  448.071743] [drm:skl_update_scaler_crtc] Updating scaler for [CRTC:26] scaler_user index 1.31
Jul  2 11:44:57 SKLY6 kernel: [  448.071749] [drm:intel_atomic_setup_scalers] crtc_state = ffff88016c2adc00 need = 0 avail = 2 scaler_users = 0x0
Jul  2 11:44:57 SKLY6 kernel: [  448.071756] [drm:skl_detach_scalers] CRTC:26 Disabled scaler id 1.0
Jul  2 11:44:57 SKLY6 kernel: [  448.071762] [drm:skl_detach_scalers] CRTC:26 Disabled scaler id 1.1
Jul  2 11:44:57 SKLY6 kernel: [  448.071978] ------------[ cut here ]------------
Jul  2 11:44:57 SKLY6 kernel: [  448.072022] WARNING: CPU: 0 PID: 3317 at drivers/gpu/drm/i915/intel_pm.c:3390 skl_update_other_pipe_wm+0x12e/0x16e [i915]()
Jul  2 11:44:57 SKLY6 kernel: [  448.072025] WARN_ON(!wm_changed)
Jul  2 11:44:57 SKLY6 kernel: [  448.072028] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hda_core snd_hwdep snd_pcm_oss snd_mixer_oss joydev snd_pcm snd_seq_dummy asix x86_pkg_temp_thermal usbnet coretemp snd_seq_oss kvm_intel kvm snd_seq_midi snd_rawmidi microcode snd_seq_midi_event snd_seq serio_raw snd_seq_device snd_timer i915 snd drm_kms_helper soundcore shpchp drm wmi battery ipv6 bnep bluetooth rfkill video parport_pc button ac acpi_cpufreq ppdev lp parport sdhci_pci sdhci led_class mmc_core
Jul  2 11:44:57 SKLY6 kernel: [  448.072107] CPU: 0 PID: 3317 Comm: kms_frontbuffer Tainted: G     U  W       4.1.0-nightly-ww27+ #7
Jul  2 11:44:57 SKLY6 kernel: [  448.072112] Hardware name: Intel Corporation Skylake Client platform/Skylake Y LPDDR3 RVP3, BIOS SKLSE2R1.R00.B088.B00.1506091425 06/09/2015
Jul  2 11:44:57 SKLY6 kernel: [  448.072115]  0000000000000009 ffff880166b6f6a8 ffffffff8188b66e 0000000000004a49
Jul  2 11:44:57 SKLY6 kernel: [  448.072123]  ffff880166b6f6f8 ffff880166b6f6e8 ffffffff810452f1 ffff880166b6f8c6
Jul  2 11:44:57 SKLY6 kernel: [  448.072130]  ffffffffa0281972 ffff880087321000 ffff88016c192000 ffff880087325000
Jul  2 11:44:57 SKLY6 kernel: [  448.072138] Call Trace:
Jul  2 11:44:57 SKLY6 kernel: [  448.072148]  [<ffffffff8188b66e>] dump_stack+0x45/0x57
Jul  2 11:44:57 SKLY6 kernel: [  448.072155]  [<ffffffff810452f1>] warn_slowpath_common+0xa1/0xbb
Jul  2 11:44:57 SKLY6 kernel: [  448.072187]  [<ffffffffa0281972>] ? skl_update_other_pipe_wm+0x12e/0x16e [i915]
Jul  2 11:44:57 SKLY6 kernel: [  448.072192]  [<ffffffff81045351>] warn_slowpath_fmt+0x46/0x48
Jul  2 11:44:57 SKLY6 kernel: [  448.072223]  [<ffffffffa0281972>] skl_update_other_pipe_wm+0x12e/0x16e [i915]
Jul  2 11:44:57 SKLY6 kernel: [  448.072255]  [<ffffffffa0281b06>] skl_update_wm+0x154/0x6d1 [i915]
Jul  2 11:44:57 SKLY6 kernel: [  448.072262]  [<ffffffff8109334d>] ? vprintk_emit+0x495/0x4af
Jul  2 11:44:57 SKLY6 kernel: [  448.072295]  [<ffffffffa0282998>] intel_update_watermarks+0x1e/0x20 [i915]
Jul  2 11:44:57 SKLY6 kernel: [  448.072349]  [<ffffffffa02daf9f>] haswell_crtc_enable+0x544/0x935 [i915]
Jul  2 11:44:57 SKLY6 kernel: [  448.072403]  [<ffffffffa02d8e6f>] __intel_set_mode+0x619/0x6de [i915]
Jul  2 11:44:57 SKLY6 kernel: [  448.072502]  [<ffffffffa02de9e7>] intel_crtc_set_config+0x3fa/0x4c4 [i915]
Jul  2 11:44:57 SKLY6 kernel: [  448.072542]  [<ffffffffa01d647f>] drm_mode_set_config_internal+0x5c/0xf7 [drm]
Jul  2 11:44:57 SKLY6 kernel: [  448.072579]  [<ffffffffa01da833>] drm_mode_setcrtc+0x37c/0x43c [drm]
Jul  2 11:44:57 SKLY6 kernel: [  448.072605]  [<ffffffffa01cddce>] drm_ioctl+0x36a/0x3e9 [drm]
Jul  2 11:44:57 SKLY6 kernel: [  448.072635]  [<ffffffffa01da4b7>] ? drm_mode_setplane+0x18a/0x18a [drm]
Jul  2 11:44:57 SKLY6 kernel: [  448.072649]  [<ffffffff81163610>] do_vfs_ioctl+0x3bb/0x47a
Jul  2 11:44:57 SKLY6 kernel: [  448.072660]  [<ffffffff8116d0ae>] ? __fget_light+0x50/0x75
Jul  2 11:44:57 SKLY6 kernel: [  448.072669]  [<ffffffff81163722>] SyS_ioctl+0x53/0x81
Jul  2 11:44:57 SKLY6 kernel: [  448.072680]  [<ffffffff81893697>] system_call_fastpath+0x12/0x6f
Jul  2 11:44:57 SKLY6 kernel: [  448.072689] ---[ end trace 2516f113855667a2 ]---
Jul  2 11:44:57 SKLY6 kernel: [  448.072773] [drm:skl_wm_flush_pipe] flush pipe A (pass 1)
Jul  2 11:44:57 SKLY6 kernel: [  448.082575] [drm:skl_wm_flush_pipe] flush pipe B (pass 3)
Jul  2 11:44:57 SKLY6 kernel: [  448.082595] [drm:intel_enable_pipe] enabling pipe B
Jul  2 11:44:57 SKLY6 kernel: [  448.082628] [drm:intel_audio_codec_enable] ELD on [CONNECTOR:55:HDMI-A-2], [ENCODER:50:TMDS-50]
Jul  2 11:44:57 SKLY6 kernel: [  448.082634] [drm:hsw_audio_codec_enable] Enable audio codec on pipe B, 36 bytes ELD
Jul  2 11:44:57 SKLY6 kernel: [  448.082653] [drm:audio_config_hdmi_pixel_clock] Configuring HDMI audio for pixel clock 148500 (0x00090000)
Jul  2 11:44:57 SKLY6 kernel: [  448.084927] [drm:intel_connector_check_state] [CONNECTOR:35:eDP-1]
Jul  2 11:44:57 SKLY6 kernel: [  448.084954] [drm:intel_connector_check_state] [CONNECTOR:55:HDMI-A-2]
Jul  2 11:44:57 SKLY6 kernel: [  448.084962] [drm:check_encoder_state] [ENCODER:34:TMDS-34]
Jul  2 11:44:57 SKLY6 kernel: [  448.084969] [drm:check_encoder_state] [ENCODER:43:TMDS-43]
Jul  2 11:44:57 SKLY6 kernel: [  448.084974] [drm:check_encoder_state] [ENCODER:45:DP MST-45]
Jul  2 11:44:57 SKLY6 kernel: [  448.084977] [drm:check_encoder_state] [ENCODER:46:DP MST-46]
Jul  2 11:44:57 SKLY6 kernel: [  448.084980] [drm:check_encoder_state] [ENCODER:47:DP MST-47]
Jul  2 11:44:57 SKLY6 kernel: [  448.084983] [drm:check_encoder_state] [ENCODER:50:TMDS-50]
Jul  2 11:44:57 SKLY6 kernel: [  448.084990] [drm:check_encoder_state] [ENCODER:52:DP MST-52]
Jul  2 11:44:57 SKLY6 kernel: [  448.084993] [drm:check_encoder_state] [ENCODER:53:DP MST-53]
Jul  2 11:44:57 SKLY6 kernel: [  448.084996] [drm:check_encoder_state] [ENCODER:54:DP MST-54]
Jul  2 11:44:57 SKLY6 kernel: [  448.085000] [drm:check_crtc_state] [CRTC:21]
Jul  2 11:44:57 SKLY6 kernel: [  448.085036] [drm:check_crtc_state] [CRTC:26]
Jul  2 11:44:57 SKLY6 kernel: [  448.085072] [drm:check_crtc_state] [CRTC:31]
Jul  2 11:44:57 SKLY6 kernel: [  448.085080] [drm:check_shared_dpll_state] DPLL 1
Jul  2 11:44:57 SKLY6 kernel: [  448.085088] [drm:check_shared_dpll_state] DPLL 2
Jul  2 11:44:57 SKLY6 kernel: [  448.085094] [drm:check_shared_dpll_state] DPLL 3
Jul  2 11:44:57 SKLY6 kernel: [  448.085159] [drm:pipe_crc_set_source] collecting CRCs for pipe A, pf
Jul  2 11:44:57 SKLY6 kernel: [  448.132615] [drm:pipe_crc_set_source] stopping CRCs for pipe A
Jul  2 11:44:57 SKLY6 kernel: [  448.199779] [drm:pipe_crc_set_source] collecting CRCs for pipe A, pf
Jul  2 11:44:57 SKLY6 kernel: [  448.249237] [drm:pipe_crc_set_source] stopping CRCs for pipe A
Jul  2 11:44:57 SKLY6 kernel: [  448.317233] [drm:pipe_crc_set_source] collecting CRCs for pipe A, pf
Jul  2 11:44:57 SKLY6 kernel: [  448.365857] [drm:pipe_crc_set_source] stopping CRCs for pipe A
Jul  2 11:44:57 SKLY6 kernel: [  448.533388] [drm:pipe_crc_set_source] collecting CRCs for pipe A, pf
Jul  2 11:44:57 SKLY6 kernel: [  448.582434] [drm:pipe_crc_set_source] stopping CRCs for pipe A
Jul  2 11:44:57 SKLY6 kernel: [  448.651133] [drm:pipe_crc_set_source] collecting CRCs for pipe A, pf
Jul  2 11:44:57 SKLY6 kernel: [  448.698985] [drm:pipe_crc_set_source] stopping CRCs for pipe A
Jul  2 11:44:57 SKLY6 kernel: [  448.766506] [drm:pipe_crc_set_source] collecting CRCs for pipe A, pf
Jul  2 11:44:57 SKLY6 kernel: [  448.815699] [drm:pipe_crc_set_source] stopping CRCs for pipe A
Jul  2 11:44:57 SKLY6 kernel: [  448.883485] [drm:pipe_crc_set_source] collecting CRCs for pipe A, pf
Jul  2 11:44:58 SKLY6 kernel: [  448.932320] [drm:pipe_crc_set_source] stopping CRCs for pipe A
Jul  2 11:44:58 SKLY6 kernel: [  449.099384] [drm:pipe_crc_set_source] collecting CRCs for pipe A, pf
Jul  2 11:44:58 SKLY6 kernel: [  449.148911] [drm:pipe_crc_set_source] stopping CRCs for pipe A
Jul  2 11:44:58 SKLY6 kernel: [  449.216603] [drm:pipe_crc_set_source] collecting CRCs for pipe A, pf
Jul  2 11:44:58 SKLY6 kernel: [  449.265444] [drm:pipe_crc_set_source] stopping CRCs for pipe A
Comment 1 Olivier Berthier 2015-07-03 12:12:49 UTC 
Created attachment 116911 [details]
dmesg log file
Comment 2 Olivier Berthier 2015-07-17 16:32:17 UTC 
Created attachment 117202 [details]
kern_log_render-flip-vs-modeset-interruptible

The crash also appear for the test igt@kms_flip@render-flip-vs-modeset-interruptible. Maybe it's the same bug.
Comment 3 Jim Bish 2015-08-05 00:47:42 UTC 
patches currently on the list: 

drm/i915:skl: Add WaEnableGapsTsvCreditFix
drm/i915:gen9: Add disable gather at set shader w/a

resolved this issue on my ticket.  Please retest with these kernel patches.

Jim
Comment 4 cprigent 2015-08-16 14:03:08 UTC 
Reassigned to Olivier to confirm if fixed.
Comment 5 Olivier Berthier 2015-08-24 15:03:40 UTC 
Created attachment 117896 [details]
dmesg log file with patches

The result is now dmesg-warn with the patches.
Comment 6 Olivier Berthier 2015-10-16 12:38:04 UTC 
Not reproduced on Sky Lake Y with the drm-intel-testing-2015-10-10 kernel and with the patches :
http://lists.freedesktop.org/archives/intel-gfx/2015-August/074657.html
http://lists.freedesktop.org/archives/intel-gfx/2015-August/074828.html.

Without the patches the DUT crash.

Setup:
------
kernel: drm-intel-testing 2015-10-10 c38f2c24fb6484fc6900efa6f8d968e8ee964e9c
cairo: 1.14.2 93422b3cb5e0ef8104b8194c8873124ce2f5ea2d 
libdrm: 2.4.65 c3496167637e35cf8a52d5e7e53a412e79d80db0
intel-driver: 1.6.1 35858c69166b845c59ca32e19a3dbb0b758df209 
libva: 1.6.1 613eb962b45fbbd1526d751e88e0d8897af6c0e0
mesa: 11.0.3 914966befcd57764941405707d8f57d3e7e7f768 
xf86-video-intel: 2.99.917 baec802b21387d04aebb10ac29e719a1800c5aa0 
xserver: 1.17.2 2123f7682d522619f101b05fb75efa75dabbe371

intel-gpu-tools: origin/master, origin/HEAD bfea74a9f64a900bcb90f946b38746781017449f
Comment 7 cprigent 2016-02-22 12:01:42 UTC 
Olivier confirmed the patches fix the crash.
Are they integrated to drm-intel-nightly?

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.