| Summary: |
[PATCH] policy: don't prevent us from receiving signals |
| Product: |
ModemManager
|
Reporter: |
David Herrmann <dh.herrmann> |
| Component: |
general | Assignee: |
ModemManager bug user <modemmanager> |
| Status: |
RESOLVED
FIXED
|
QA Contact: |
|
| Severity: |
normal
|
|
|
| Priority: |
medium
|
|
|
| Version: |
unspecified | |
|
| Hardware: |
Other | |
|
| OS: |
All | |
|
| Whiteboard: |
|
|
i915 platform:
|
|
i915 features:
|
|
|---|
| Attachments: |
[PATCH] policy: don't prevent us from receiving signals
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 117135 [details] [PATCH] policy: don't prevent us from receiving signals Hi By using: <deny send_destination="org.freedesktop.ModemManager1"/> ..we prevent anyone on the system from sending us signals, even if we subscribed to them. This is clearly not what this line intended. More importantly, we silently break mm-auth-provider-polkit, as we never receiver 'changed' signals via PolkitAuthority. Right now, this is not required by the implementation of PolkitAuthority, but ModemManager should not place restrictions on the implementation of external libraries. So make sure we only prevent Method-Calls to be sent to us. Any other message that we didn't expect is automatically discarded by gdbus, anyway. Without this change, debugging dbus policies constantly shows messages that Polkit couldn't send the 'changed' signal to ModemManager. This is suppressed in non-debugging mode. But it would make debugging a lot easier, if we'd avoid force-dropping those events and not clutter the debug-log.