| Summary: | test/tap-test.sh.in not shipped in the 1.9.20 tarball | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Tyler Hicks <tyhicks> |
| Component: | core | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | D-Bus Maintainers <dbus> |
| Severity: | minor | ||
| Priority: | medium | ||
| Version: | git master | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Distribute tap-test.sh.in unconditionally
audit: make the first few fds close-on-exec |
||
|
Description
Tyler Hicks
2015-08-18 23:03:24 UTC
Created attachment 117794 [details] [review] Distribute tap-test.sh.in unconditionally --- Review welcome (from anyone). It's pretty trivial, so I'll apply it unreviewed if nobody objects soon. Comment on attachment 117794 [details] [review] Distribute tap-test.sh.in unconditionally Looks correct to me. Hijacking this bug a bit, on the Ubuntu-inclusion bug, Tyler said > However, even after pulling in that file from the git tree, `make check` > is still failing on the test-bus.sh test. I can reproduce this, and I think this is actually a bug in libcap-ng: <https://bugs.debian.org/796167>. If I'm right, configuring with --enable-tests --enable-asserts --disable-libaudit will make this go away. Created attachment 117795 [details] [review] audit: make the first few fds close-on-exec libcap-ng < 0.7.7 leaks one non-close-on-exec fd during initialization. test-bus asserts that all fds beyond 2 passed to an executed subprocess have the close-on-exec flag set, which will fail at that leaked fd. This was unnoticed until commit 517c4685, because libaudit was previously only initialized if we were configured to switch uid, which the regression tests do not do; the system bus is normally the only place that happens, but the system bus is not normally run with the "embedded tests" enabled (since they are bad for performance and security). Comment on attachment 117795 [details] [review] audit: make the first few fds close-on-exec Review of attachment 117795 [details] [review]: ----------------------------------------------------------------- If this fixes the tests, it looks good to me (as good as a hack can ever look, anyway). Both applied in what is going to become dbus 1.10.0. Why not just bump the version of the libcap-ng dependency? Sounds wrong to me to work around old, broken software. (In reply to Lennart Poettering from comment #7) > Why not just bump the version of the libcap-ng dependency? The fix isn't particularly old (this May), and this stable-branch has taken more than a year already. I don't want to gate "we can have a stable release that passes tests" on distributions all updating libcap-ng. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.