Bug 91716

Summary:	[bisected] piglit.shaders.glsl-vs-int-attrib regresses on 32 bit BYT, HSW, IVB, SNB
Product:	Mesa	Reporter:	Mark Janes <mark.a.janes>
Component:	Drivers/DRI/i965	Assignee:	Ian Romanick <idr>
Status:	RESOLVED FIXED	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	normal
Priority:	medium	CC:	apuentes, jason, mark.a.janes
Version:	git
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Mark Janes 2015-08-21 15:22:29 UTC

Using NIR for vertex shaders regressed shaders.glsl-vs-int-attrib on some 32 bit hardware.

All platforms exhibit the same failure pattern:

piglit/bin/glsl-vs-int-attrib -auto -fbo

Probe color at (0,0) Expected: 0.000000 1.000000 0.000000
Observed: 1.000000 0.000000 0.000000


FWIW, this test was fixed for m32 earlier at mesa 1a93e7690dc90211164082d6a2d26d93da8127ef

Comment 1 Jason Ekstrand 2015-09-10 23:58:50 UTC

The following patch should fix this bug:

http://lists.freedesktop.org/archives/mesa-dev/2015-August/092474.html

While that patch will apply cleanly, you also need the first patch in the series or you'll get more regressions.  The two together does seem to fix this though.

Comment 2 Jason Ekstrand 2015-09-14 19:18:00 UTC

Fixed by:

commit b8d2263c83d29f4626ac0fe0316978aa6262aefb
Author: Antia Puentes <apuentes@igalia.com>
Date:   Mon Sep 14 09:50:59 2015 +0200

    i965/vec4_nir: Load constants as integers
    
    Loads constants using integer as their register type, like it is
    done in FS backend.
    
    No shader-db changes in HSW.
    
    Cc: "10.6 11.0" <mesa-stable@lists.freedesktop.org>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91716
    Reviewed-by: Jason Ekstrand <jason.ekstrand@intel.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.