| Summary: | c8da19b50a30d840484383f41e0218814f1501a0 makes scroll too sensitive on x230 | ||
|---|---|---|---|
| Product: | Wayland | Reporter: | Vasily Khoruzhick <anarsoul> |
| Component: | libinput | Assignee: | Wayland bug list <wayland-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | peter.hutterer |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Vasily Khoruzhick
2015-08-31 01:40:13 UTC
https://github.com/whot/libinput/tree/wip/x230-const-filter how's this one? Perfect! Thanks! commit 6a0f9411f232148b297de40456dcbafc07067cd2 Author: Peter Hutterer <peter.hutterer@who-t.net> Date: Mon Aug 31 14:05:11 2015 +1000 filter: fix constant acceleration for the X230 Out of curiosity I was looking at the libinput source code, and I found this latest diff. Now I am wondering: Aren't magic numbers part of the reason why people dislike X? And how long are X230 magic constants supposed to stay around in the source tree? And what happens as soon as new magic numbers for other touchpads are needed? Seems like a very odd decision to not make these things configuration variables. Sorry if this comment comes out in the wrong way. I am a big fan of the recent Wayland progress! the x230 constants will stay around for a fair while, they're now separated enough that we don't really need to think about them beyond making sure they build (and that we don't modify them). And the infrastructure is there to add more magic numbers where needed. yes, we could expose magic knobs for them but those knobs may not actually provide the ability to fix it in a sensible manner and then you also rely on people either figuring out the knobs or copying them from various non-authoritative sources. There's enough garbage configurations out there already, we don't need to add too them. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.