| Summary: | [patch] Add support for NetBSD | ||
|---|---|---|---|
| Product: | PolicyKit | Reporter: | OBATA Akio <obache> |
| Component: | daemon | Assignee: | David Zeuthen (not reading bugmail) <zeuthen> |
| Status: | RESOLVED FIXED | QA Contact: | David Zeuthen (not reading bugmail) <zeuthen> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | NetBSD | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Add support for NetBSD | ||
|
Description
OBATA Akio
2015-09-19 09:25:02 UTC
Comment on attachment 118360 [details] [review] Add support for NetBSD Review of attachment 118360 [details] [review]: ----------------------------------------------------------------- Thanks for the patch. Do you want to provide a new tested version without that OS_TYPE_NETBSD line, or shall I just remove it and commit it untested? Either way is fine with me. ::: configure.ac @@ +472,4 @@ > AM_CONDITIONAL(OS_TYPE_PARDUS, test x$with_os_type = xpardus, [Running on Pardus OS'es]) > AM_CONDITIONAL(OS_TYPE_SOLARIS, test x$with_os_type = xsolaris, [Running os Solaris OS'es]) > AM_CONDITIONAL(OS_TYPE_FREEBSD, test x$with_os_type = xfreebsd, [Running on FreeBSD OS'es]) > +AM_CONDITIONAL(OS_TYPE_NETBSD, test x$with_os_type = xnetbsd, [Running on NetBSD OS'es]) OS_TYPE_* are not used anywhere, so this is not necessary. (None of the others are necessary either, let’s at least not add more.) Yes, please drop it and commit. I've tested without the line, and added it to follow others. Committed, thanks! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.