Bug 92104

Summary: BUILD ERROR caused by wrong inclusion-(order)
Product: Wayland Reporter: ahmet_acar <unixman>
Component: westonAssignee: Wayland bug list <wayland-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: full build-log attached
a trivial patch to fix #92104

Description ahmet_acar 2015-09-24 15:00:31 UTC
Hi. When i trying to build weston-master i got:

CCLD     desktop-shell.la
CC       clients/libtoytoolkit_la-window.lo
In file included from /usr/include/EGL/egl.h:39:0,
                 from ./shared/platform.h:32,
                 from clients/window.h:34,
                 from clients/window.c:76:
/usr/include/EGL/eglplatform.h:119:22: fatal error: X11/Xlib.h: No such file or d

This is because <EGL/egl.h> included when WL_EGL_PLATFORM is not defined.So i 

fixed this bug by putting 

#include <wayland-egl.h> on above of line of #include <EGL/egl.h> in 

shared/platform.h

wayland-1.9.0  This is my flags :

./configure --prefix=/usr --libexecdir=/usr/lib/weston --disable-setuid-install --disable-xwayland --disable-rpi-compositor --disable-rdp-compositor --disable-ivi-shell --disable-x11-compositor --disable-headless-compositor --disable-fbdev-compositor --disable-demo-clients-install --disable-screen-sharing --disable-vaapi-recorder --disable-simple-clients --disable-simple-egl-clients --disable-simple-intel-dmabuf-client --disable-resize-optimization --disable-weston-launch --disable-wcap-tools --disable-fullscreen-shell
Comment 1 ahmet_acar 2015-09-24 15:02:53 UTC
Created attachment 118434 [details]
full build-log attached

full build log
Comment 2 ahmet_acar 2015-09-24 15:57:46 UTC
Created attachment 118435 [details] [review]
a trivial patch to fix #92104

a trivial patch to fix #92104
Comment 3 ahmet_acar 2015-09-24 15:59:22 UTC
to fix:
---
 shared/platform.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/shared/platform.h b/shared/platform.h
index 64e1fbf..cf4ecc0 100644
--- a/shared/platform.h
+++ b/shared/platform.h
@@ -29,6 +29,7 @@
 #include <string.h>
 
 #ifdef ENABLE_EGL
+#include <wayland-egl.h>
 #include <EGL/egl.h>
 #include <EGL/eglext.h>
 #endif
-- 
2.5.3
Comment 4 Derek Foreman 2015-11-13 16:35:41 UTC
Thanks for fixing this.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.