| Summary: | Adding Finnish DAS layout, includes a patch | ||
|---|---|---|---|
| Product: | xkeyboard-config | Reporter: | Tomi Leppänen <tomi.leppanen> |
| Component: | General | Assignee: | xkb |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | myllynen, peter.hutterer |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
[PATCH] Added Finnish DAS layout
[PATCH] Move Finnish DAS layout to extras |
||
|
Description
Tomi Leppänen
2015-09-28 18:46:47 UTC
Comment on attachment 118499 [details]
[PATCH] Added Finnish DAS layout
It seems that the layout is based on the old Finnish layout, not the current one with support for Unicode, and many more characters through the use of diacritics etc.
Did you contact the Kotoistus project at any point? As a long term member of Kotoistus, I was not notified of your project as far as I can recall. Of course it could be I was told about this and simply didn't follow up on it...
It is a shame. I would have been interested in merging the new standard layout with yours, to get the benefits of the new layout integrated into this DAS layout as well.
Anyway, water under the bridge now.
I don't see any reason not to accept this new layout. It would be nice to have had the extended repertoire of characters available, but maybe in the future then.
Well that layout is quite old, made back in 2008, and I didn't make it. DAS layout is Cristian Seres' invention and that xkb_symbols definition is actually made by Joel Lehtonen as I said earlier. I didn't contact kotoistus as I didn't realise that there was any need to do so. I don't think it is too late to make it better. I just think that we should contact Cristian if we're going to make any changes to the layout. Personally I'm open to suggestions to improve the layout. There is quite a lot of empty space in the 3rd (and 4th) layer. The reason why I made this patch is that I felt it is finally time to include this layout in Xorg. For a few years I've been patching the files up myself using the Python script that is available at the homepage of DAS layout. More about DAS and Christian's email can be found at: http://c.seres.fi/DAS.html (in Finnish) http://c.seres.fi/DAS_en.html (less information but in English) How many people do use this layout? Any estimations? Unfortunately the patch does not work with the current git code. Could you please update it? It will go into the next xk-c release. Sorry, I was wrong. The patch applied in git. Please check. (In reply to Sergey V. Udaltsov from comment #3) > How many people do use this layout? Any estimations? I asked Cristian about this and he responded me with this: About 80 persons have personally contacted the inventor of the DAS layout since 2004. Install files for the DAS keyboard layout have been downloaded over 950 times since January 2015. That's all I know and I included that in the bugreport already. (In reply to Sergey V. Udaltsov from comment #4) > Sorry, I was wrong. The patch applied in git. Please check. Looks fine to me. Thank you. (In reply to Tomi Leppänen from comment #5) > (In reply to Sergey V. Udaltsov from comment #3) > > How many people do use this layout? Any estimations? > > I asked Cristian about this and he responded me with this: > About 80 persons have personally contacted the inventor of the DAS > layout since 2004. Install files for the DAS keyboard layout have been > downloaded over 950 times since January 2015. Given these low numbers I think this layout should have been added to base.extras.xml.in not to base.xml.in, IMHO this would in accordance of the Section 6 of the Layouts, Variants chapter of https://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules/. Having these kind of rarely used, unknown-to-most-people layouts just causes unnecessary confusion when people see something incomprehensible like "Finnish (DAS)" in the installer / keyboard selection tool. Thanks. Created attachment 125132 [details] [review] [PATCH] Move Finnish DAS layout to extras This patch moves Finnish (DAS) layout to base.extras.xml (In reply to Marko Myllynen from comment #6) > (In reply to Tomi Leppänen from comment #5) > > (In reply to Sergey V. Udaltsov from comment #3) > > > How many people do use this layout? Any estimations? > > > > I asked Cristian about this and he responded me with this: > > About 80 persons have personally contacted the inventor of the DAS > > layout since 2004. Install files for the DAS keyboard layout have been > > downloaded over 950 times since January 2015. > > Given these low numbers I think this layout should have been added to > base.extras.xml.in not to base.xml.in, IMHO this would in accordance of the > Section 6 of the Layouts, Variants chapter of > https://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules/. I made a patch for this. > Having these kind of rarely used, unknown-to-most-people layouts just causes > unnecessary confusion when people see something incomprehensible like > "Finnish (DAS)" in the installer / keyboard selection tool. It's too bad that Gnome doesn't have a button to expose these extra layouts. Now the user must use gnome-tweak-tool or set gsettings value to see these layouts. Personally I don't consider DAS very exotic or anything, but yeah, there aren't that many users. (In reply to Tomi Leppänen from comment #8) > (In reply to Marko Myllynen from comment #6) > > (In reply to Tomi Leppänen from comment #5) > > > (In reply to Sergey V. Udaltsov from comment #3) > > > > How many people do use this layout? Any estimations? > > > > > > I asked Cristian about this and he responded me with this: > > > About 80 persons have personally contacted the inventor of the DAS > > > layout since 2004. Install files for the DAS keyboard layout have been > > > downloaded over 950 times since January 2015. > > > > Given these low numbers I think this layout should have been added to > > base.extras.xml.in not to base.xml.in, IMHO this would in accordance of the > > Section 6 of the Layouts, Variants chapter of > > https://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules/. > > I made a patch for this. Thanks! > > Having these kind of rarely used, unknown-to-most-people layouts just causes > > unnecessary confusion when people see something incomprehensible like > > "Finnish (DAS)" in the installer / keyboard selection tool. > > It's too bad that Gnome doesn't have a button to expose these extra layouts. > Now the user must use gnome-tweak-tool or set gsettings value to see these > layouts. It indeed sounds a bit more complicated than it ideally could be - do you know has there been GNOME RFEs about this? If not, perhaps we should file one.. Thanks. Perfect, thank you, committed! late follow-up: Sergey, please make sure the commit messages have a bug link in them, especially when they're preceded by some discussion rather than being obvious bugfixes. Makes figuring out why something happens a lot easier. (In reply to Peter Hutterer from comment #11) > late follow-up: Sergey, please make sure the commit messages have a bug link > in them, especially when they're preceded by some discussion rather than > being obvious bugfixes. Makes figuring out why something happens a lot > easier. Will try! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.