Bug 9219

Summary:

NameWindowPixmap on an unmapped window names the screen pixmap

Product:

xorg

Reporter:

Aaron Plattner <aplattner>

Component:

Server/General

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

high

Version:

git

Hardware:

x86 (IA32)

OS:

Linux (All)

Whiteboard:

i915 platform:

i915 features:

Bug Depends on:

Bug Blocks:

6666

Attachments:

Description	Flags
Test app	none

Description Aaron Plattner 2006-12-01 15:51:11 UTC

Calling XNameWindowPixmap on an unmapped window ends up naming the screen
pixmap.  This can really confuse things if a client, say, tries to use
glXBindTexImage2D on it.

Comment 1 Aaron Plattner 2006-12-01 15:51:54 UTC

Created attachment 7943 [details]
Test app

Comment 2 Aaron Plattner 2006-12-05 12:44:28 UTC

commit 3690de9b1b0902d395bc7d071fc05ebc8f75be2b
Author: Aaron Plattner <aplattner@nvidia.com>
Date:   Tue Dec 5 12:42:12 2006 -0800

    Bug #9219: Return BadMatch when trying to name the backing pixmap of an
    unrealized window.
    
    Before this change, ProcCompositeNameWindowPixmap would name the screen pixmap
    if !pWin->realized.

:100644 100644 a7ad4e2... ec5e1fa... M  composite/compext.c

Still needs cherry-picking to server-1.2-branch.

Comment 3 Aaron Plattner 2006-12-05 13:47:36 UTC

I'm dumb.  InputOnly windows have the same problem.

commit 724f9cb578086e8483a2d0636dd6eb05d664d31c
Author: Aaron Plattner <aplattner@nvidia.com>
Date:   Tue Dec 5 13:44:05 2006 -0800

    Bug #9219: Use pWin->viewable instead of pWin->realized to catch InputOnly
windows too.

:100644 100644 ec5e1fa... 13936fa... M  composite/compext.c

Comment 4 Adam Jackson 2006-12-10 15:26:07 UTC

Cherried back to 1.2, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.