Bug 92245

Summary:	build fails with glib 2.46 due to duplicated tests
Product:	Telepathy	Reporter:	Sebastien Bacher <seb128>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	iain
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Don't use the same test name for multiple tests Remove a G_GNUC_UNUSED which isn't true any more

Description Sebastien Bacher 2015-10-02 14:03:18 UTC

Using glib 2.46 makes telepathy-glib fails to build due to duplicated tests

FAIL: test-account
==================


(telepathy-glib-0.24.1/tests/dbus/.libs/lt-test-account:1891):
GLib-ERROR **: duplicate test case path: /account/reconnect
FAIL test-account (exit status: 133)

FAIL: test-cm
=============


(telepathy-glib-0.24.1/tests/dbus/.libs/lt-test-cm:2334): GLib-ERROR **:
duplicate test case path: /cm/list
FAIL test-cm (exit status: 133)

FAIL: test-contact-lists
========================


(telepathy-glib-0.24.1/tests/dbus/.libs/lt-test-contact-lists:2819):
GLib-ERROR **: duplicate test case path:
/contact-lists/cancelled-publish-request
FAIL test-contact-lists (exit status: 133)

FAIL: test-contact-list-client
==============================


(telepathy-glib-0.24.1/tests/dbus/.libs/lt-test-contact-list-client:2864):
GLib-ERROR **: duplicate test case path:
/contact-list-client/contact-list/properties
FAIL test-contact-list-client (exit status: 133)

Comment 1 Iain Lane 2015-10-02 14:33:58 UTC

Created attachment 118608 [details] [review]
Don't use the same test name for multiple tests

GLib 2.46.0 doesn't allow this any more, and so the testsuite fails.

Comment 2 Iain Lane 2015-10-02 14:34:11 UTC

Created attachment 118609 [details] [review]
Remove a G_GNUC_UNUSED which isn't true any more

Noticed this and thought I'd sneak it here.

Comment 3 George Kiagiadakis 2016-06-20 09:55:32 UTC

Fixed in master. Unfortunately I did not notice your patch before fixing it myself. The fix is the same. I pushed your second patch as-is, though

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.