Bug 92293

Created attachment 118675 [details]
attachment-24069-0.html

Seems dri_interface.h is missing from intel_screen.c file.
But even adding it ,mesa have compilation error: no rule to make target nir/nir_...

From: mesa-dev [mailto:mesa-dev-bounces@lists.freedesktop.org] On Behalf Of bugzilla-daemon@freedesktop.org
Sent: Monday, October 05, 2015 6:13 PM
To: mesa-dev@lists.freedesktop.org
Subject: [Mesa-dev] [Bug 92293] A compilation error happen when update mesa from 10.6.7 to 11.0.2

Bug ID

92293<https://bugs.freedesktop.org/show_bug.cgi?id=92293>

Summary

A compilation error happen when update mesa from 10.6.7 to 11.0.2

Product

Mesa

Version

11.0

Hardware

x86-64 (AMD64)

OS

Linux (All)

Status

NEW

Severity

normal

Priority

medium

Component

Mesa core

Assignee

mesa-dev@lists.freedesktop.org<mailto:mesa-dev@lists.freedesktop.org>

Reporter

olivierx.berthier@intel.com<mailto:olivierx.berthier@intel.com>

QA Contact

mesa-dev@lists.freedesktop.org<mailto:mesa-dev@lists.freedesktop.org>


Created attachment 118674 [details]<attachment.cgi?id=118674> [details]<attachment.cgi?id=118674&action=edit>

full build log



Setup:

------



kernel 4.3.0-rc3-drm-intel-nightly+

cairo: (HEAD, tag: 1.14.2) 93422b3cb5e0ef8104b8194c8873124ce2f5ea2d from

git://git.freedesktop.org/git/cairo

drm: (HEAD, tag: libdrm-2.4.64, tag: 2.4.64)

ab2fadabde3829b1ec56bd4756165dd9bd281488 from

git://git.freedesktop.org/git/mesa/drm

intel-driver: (HEAD, origin/master, origin/HEAD, master)

2a72f99d24714f2a58f400ef63b913d4cf9080b3 from

git://git.freedesktop.org/git/vaapi/intel-driver

libva: (HEAD, tag: libva-1.6.1, origin/v1.6-branch)

613eb962b45fbbd1526d751e88e0d8897af6c0e0 from

git://git.freedesktop.org/git/vaapi/libva

mesa: (HEAD, tag: mesa-11.0.2) 51e0b06d9916e126060c0d218de1aaa4e5a4ce26 from

git://git.freedesktop.org/git/mesa/mesa

xf86-video-intel: (HEAD, origin/master, origin/HEAD, master)

f0fd4d500de03c30c7ce19915f85acadd1ca4e5d from

git://git.freedesktop.org/git/xorg/driver/xf86-video-intel

xserver: (HEAD, tag: xorg-server-1.17.2)

2123f7682d522619f101b05fb75efa75dabbe371 from

git://git.freedesktop.org/git/xorg/xserver



Steps:

------

1. Update mesa sources to 11.0.2 tag and clean the build directory

2. Configure mesa :



/home/qa/dev/graphic/stack/mesa/mesa/autogen.sh ACLOCAL="aclocal -I

/home/qa/dev/graphic/build/usr/local/share/aclocal"

LDFLAGS="-L/home/qa/dev/graphic/build/usr/local/lib"

CPPFLAGS="-I/home/qa/dev/graphic/build/usr/local/include/"

PKG_CONFIG_PATH="/home/qa/dev/graphic/build/usr/local/share/pkgconfig:/home/qa/dev/graphic/build/usr/local/lib/pkgconfig:/home/qa/dev/graphic/build/usr/local/lib/x86_64-linux-gnu/pkgconfig"

--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu

--prefix=/home/qa/dev/graphic/build/usr/local

--libdir=/home/qa/dev/graphic/build/usr/local/lib

--includedir=/home/qa/dev/graphic/build/usr/local/include --disable-static

--enable-debug --disable-docs  --with-dri-drivers='i915 i965 swrast'

--enable-gles1 --enable-gles2 --enable-shared-glapi

--with-egl-platforms=x11,drm --enable-texture-float --enable-gbm

--enable-glx-tls --disable-dri2 --disable-dri3 --with-gallium-drivers=''

--disable-gallium-llvm

--with-dri-driverdir=/home/qa/dev/graphic/build/usr/local/lib/dri



3. Run make

4. Remove the GL, EGL, GLES, GLES2 and GLES3 directories from include path

(/home/qa/dev/graphic/build/usr/local/include/).

5. Replay the steps 2 and 3.



Actual result:

---------------

At the step 3, the compilation fail :



...

...

make[5]: Entering directory

`/home/qa/dev/graphic/tmp/mesa/mesa/build/amd64/src/mesa/drivers/dri/i965'

  CC       brw_binding_tables.lo

  CXX      brw_blorp_blit.lo

  CXX      brw_blorp_blit_eu.lo

  CC       brw_cc.lo

  CXX      brw_blorp.lo

  CXX      brw_cfg.lo

  CC       brw_clear.lo

  CC       brw_clip.lo

  CC       brw_clip_line.lo

  CC       brw_clip_point.lo

  CC       brw_clip_state.lo

  CC       brw_clip_tri.lo

  CC       brw_clip_unfilled.lo

  CC       brw_clip_util.lo

  CC       brw_compute.lo

  CC       brw_conditional_render.lo

  CXX      brw_cs.lo

  CC       brw_context.lo

  CC       brw_curbe.lo

  CXX      brw_cubemap_normalize.lo

  CXX      brw_dead_control_flow.lo

  CC       brw_device_info.lo

  CC       brw_disasm.lo

  CC       brw_draw.lo

  CC       brw_draw_upload.lo

  CC       brw_eu.lo

  CC       brw_eu_compact.lo

  CC       brw_eu_emit.lo

  CC       brw_eu_util.lo

  CC       brw_ff_gs.lo

  CC       brw_ff_gs_emit.lo

  CXX      brw_fs_channel_expressions.lo

  CXX      brw_fs_cmod_propagation.lo

  CXX      brw_fs_combine_constants.lo

  CXX      brw_fs_copy_propagation.lo

  CXX      brw_fs.lo

  CXX      brw_fs_cse.lo

  CXX      brw_fs_dead_code_eliminate.lo

  CXX      brw_fs_generator.lo

  CXX      brw_fs_live_variables.lo

  CXX      brw_fs_nir.lo

  CXX      brw_fs_peephole_predicated_break.lo

  CXX      brw_fs_reg_allocate.lo

  CXX      brw_fs_register_coalesce.lo

  CXX      brw_fs_sel_peephole.lo

  CXX      brw_fs_saturate_propagation.lo

  CXX      brw_fs_surface_builder.lo

  CXX      brw_fs_vector_splitting.lo

  CXX      brw_fs_visitor.lo

  CC       brw_gs.lo

  CC       brw_gs_state.lo

  CC       brw_gs_surface_state.lo

  CC       brw_interpolation_map.lo

  CXX      brw_lower_texture_gradients.lo

  CXX      brw_lower_unnormalized_offset.lo

  CC       brw_meta_fast_clear.lo

  CC       brw_meta_stencil_blit.lo

  CC       brw_meta_updownsample.lo

  CC       brw_meta_util.lo

  CC       brw_nir.lo

  CC       brw_misc_state.lo

  CC       brw_nir_analyze_boolean_resolves.lo

  CC       brw_object_purgeable.lo

  CC       brw_packed_float.lo

  CC       brw_performance_monitor.lo

  CC       brw_pipe_control.lo

  CC       brw_primitive_restart.lo

  CC       brw_program.lo

  CC       brw_queryobj.lo

  CC       brw_reset.lo

  CC       brw_sampler_state.lo

  CXX      brw_schedule_instructions.lo

  CC       brw_sf_emit.lo

  CC       brw_sf.lo

  CC       brw_sf_state.lo

  CXX      brw_shader.lo

  CC       brw_state_batch.lo

  CC       brw_state_cache.lo

  CC       brw_state_dump.lo

  CC       brw_state_upload.lo

  CC       brw_surface_formats.lo

  CC       brw_tex.lo

  CC       brw_util.lo

  CXX      brw_vec4_copy_propagation.lo

  CXX      brw_vec4.lo

  CXX      brw_vec4_cse.lo

  CXX      brw_vec4_generator.lo

  CXX      brw_vec4_gs_visitor.lo

  CC       brw_urb.lo

  CXX      brw_vec4_live_variables.lo

  CXX      brw_vec4_nir.lo

  CXX      brw_vec4_gs_nir.lo

  CXX      brw_vec4_reg_allocate.lo

  CXX      brw_vec4_visitor.lo

  CXX      brw_vec4_vp.lo

  CC       brw_tex_layout.lo

  CXX      brw_vec4_dead_code_eliminate.lo

  CXX      brw_vec4_vs_visitor.lo

  CC       brw_vs.lo

  CC       brw_vs_state.lo

  CC       brw_vs_surface_state.lo

  CC       brw_vue_map.lo

  CC       brw_wm.lo

  CXX      brw_wm_iz.lo

  CC       brw_wm_state.lo

  CC       brw_wm_surface_state.lo

  CXX      gen6_blorp.lo

  CC       gen6_cc.lo

  CC       gen6_clip_state.lo

  CC       gen6_depth_state.lo

  CC       gen6_depthstencil.lo

  CC       gen6_gs_state.lo

  CC       gen6_multisample_state.lo

  CC       gen6_queryobj.lo

  CXX      gen6_gs_visitor.lo

  CC       gen6_sampler_state.lo

  CC       gen6_scissor_state.lo

  CC       gen6_sf_state.lo

  CC       gen6_sol.lo

  CC       gen6_surface_state.lo

  CC       gen6_urb.lo

  CC       gen6_viewport_state.lo

  CC       gen6_vs_state.lo

  CC       gen6_wm_state.lo

  CXX      gen7_blorp.lo

  CC       gen7_disable.lo

  CC       gen7_gs_state.lo

  CC       gen7_misc_state.lo

  CC       gen7_sol_state.lo

  CC       gen7_sf_state.lo

  CC       gen7_urb.lo

  CC       gen7_vs_state.lo

  CC       gen7_viewport_state.lo

  CC       gen7_wm_state.lo

  CC       gen7_wm_surface_state.lo

  CC       gen8_blend_state.lo

  CC       gen8_depth_state.lo

  CC       gen8_disable.lo

  CC       gen8_gs_state.lo

  CC       gen8_draw_upload.lo

  CC       gen8_ps_state.lo

  CC       gen8_misc_state.lo

  CC       gen8_multisample_state.lo

  CC       gen8_sf_state.lo

  CC       gen8_sol_state.lo

  CC       gen8_surface_state.lo

  CC       gen8_viewport_state.lo

  CC       gen8_vs_state.lo

  CC       gen8_wm_depth_stencil.lo

  CC       intel_asm_annotation.lo

  CC       intel_batchbuffer.lo

  CC       intel_blit.lo

  CC       intel_buffer_objects.lo

  CC       intel_buffers.lo

  CC       intel_copy_image.lo

  CC       intel_debug.lo

  CC       intel_extensions.lo

  CC       intel_fbo.lo

  CC       intel_mipmap_tree.lo

  CC       intel_pixel_bitmap.lo

  CC       intel_pixel.lo

  CC       intel_pixel_copy.lo

  CC       intel_pixel_draw.lo

  CC       intel_pixel_read.lo

  CC       intel_resolve_map.lo

  CC       intel_screen.lo

  CC       intel_state.lo

  CC       intel_syncobj.lo

  CC       intel_tex.lo

  CC       intel_tex_copy.lo

  CC       intel_tex_image.lo

  CC       intel_tex_subimage.lo

  CC       intel_tex_validate.lo

  CC       intel_tiled_memcpy.lo

  CC       intel_upload.lo

/home/qa/dev/graphic/stack/mesa/mesa/src/mesa/drivers/dri/i965/intel_screen.c:232:6:

error: ‘__DRI_IMAGE_FOURCC_R8’ undeclared here (not in a function)

    { __DRI_IMAGE_FOURCC_R8, __DRI_IMAGE_COMPONENTS_R, 1,

      ^

/home/qa/dev/graphic/stack/mesa/mesa/src/mesa/drivers/dri/i965/intel_screen.c:232:29:

error: ‘__DRI_IMAGE_COMPONENTS_R’ undeclared here (not in a function)

    { __DRI_IMAGE_FOURCC_R8, __DRI_IMAGE_COMPONENTS_R, 1,

                             ^

/home/qa/dev/graphic/stack/mesa/mesa/src/mesa/drivers/dri/i965/intel_screen.c:235:6:

error: ‘__DRI_IMAGE_FOURCC_GR88’ undeclared here (not in a function)

    { __DRI_IMAGE_FOURCC_GR88, __DRI_IMAGE_COMPONENTS_RG, 1,

      ^

/home/qa/dev/graphic/stack/mesa/mesa/src/mesa/drivers/dri/i965/intel_screen.c:235:31:

error: ‘__DRI_IMAGE_COMPONENTS_RG’ undeclared here (not in a function)

    { __DRI_IMAGE_FOURCC_GR88, __DRI_IMAGE_COMPONENTS_RG, 1,

                               ^

make[5]: *** [intel_screen.lo] Error 1

make[5]: Leaving directory

`/home/qa/dev/graphic/tmp/mesa/mesa/build/amd64/src/mesa/drivers/dri/i965'

make[4]: *** [all-recursive] Error 1

make[4]: Leaving directory

`/home/qa/dev/graphic/tmp/mesa/mesa/build/amd64/src/mesa/drivers/dri'

make[3]: *** [all-recursive] Error 1

make[3]: Leaving directory

`/home/qa/dev/graphic/tmp/mesa/mesa/build/amd64/src/mesa'

make[2]: *** [all] Error 2

make[2]: Leaving directory

`/home/qa/dev/graphic/tmp/mesa/mesa/build/amd64/src/mesa'

make[1]: *** [all-recursive] Error 1

make[1]: Leaving directory `/home/qa/dev/graphic/tmp/mesa/mesa/build/amd64/src'

make: *** [all-recursive] Error 1





After the step 4, everything work fine.



Expected result:

----------------

The upgrade from mesa 10.6.7 to mesa 11.0.2 works without deleting the old

include directories.





I attach the full build log.

________________________________
You are receiving this mail because:

  *   You are the QA Contact for the bug.
  *   You are the assignee for the bug.

I think the general problem is that if you install an old version of Mesa somewhere and then try and build a new version while specifying the install prefix of the old version as an include path with -I in the CPPFLAGS then it will end up picking up the old installed headers instead of the ones that are internal to the Mesa source tree. In this case the problematic header is GL/internal/dri_interface.h, but there are others. It doesn't seem like this is such an unusual thing to do so it would be nice if it worked.

Note, in this case it was being built out-of-tree, but I'm not sure if that's necessary to replicate the bug.

(In reply to marius predut from comment #1)
> Created attachment 118675 [details]
> attachment-24069-0.html
> 
> Seems dri_interface.h is missing from intel_screen.c file.
> But even adding it ,mesa have compilation error: no rule to make target
> nir/nir_...
> 
Can you open a separate bug for this ? I'm suspecting that something strange is happening on your setup, as I haven't seen such problems for a very long time.

As a quick test, I would suggest dropping the CPPFLAGS and (optionally LDFLAGS). PKG_CONFIG_PATH will provide the relevant bits as needed.

(In reply to Neil Roberts from comment #2)
> I think the general problem is that if you install an old version of Mesa
> somewhere and then try and build a new version while specifying the install
> prefix of the old version as an include path with -I in the CPPFLAGS then it
> will end up picking up the old installed headers instead of the ones that
> are internal to the Mesa source tree. In this case the problematic header is
> GL/internal/dri_interface.h, but there are others. It doesn't seem like this
> is such an unusual thing to do so it would be nice if it worked.
> 
> Note, in this case it was being built out-of-tree, but I'm not sure if
> that's necessary to replicate the bug.

I've been building mesa OOT for 2+ years, and I'm afraid that I've not hit headers issues. If you can come up with some examples/how to, that'll be appreciated.

There is some (re-)linking fun, when libtool 'inserts' -L/usr/lib prior to -L/custom/prefix, but that will require a massive rewrite on our side :'(