Bug 92377

Summary: Add support for early voltage table as seen on nv43
Product: xorg Reporter: Andrew Randrianasulu <randrik>
Component: Driver/nouveauAssignee: Nouveau Project <nouveau>
Status: RESOLVED MOVED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
i915 platform: i915 features:
Description Flags
vbios as extracted by envytools
vbios as extracted by envytools, try 2 none

Description Andrew Randrianasulu 2015-10-10 05:07:52 UTC
Created attachment 118791 [details]
vbios as extracted by envytools

Latest nouveau (after 4.2) started to refuse to change clocks on my nv43 board. Investigation showed it was simply failing to find voltage table, while such table was recognized by nvbios tool from envytools.

So, I've added patch along those lines:

    diff --git a/drm/nouveau/nvkm/subdev/bios/volt.c b/drm/nouveau/nvkm/subdev/bios/volt.c
    index 6e0a336..3e9dafa 100644
    --- a/drm/nouveau/nvkm/subdev/bios/volt.c
    +++ b/drm/nouveau/nvkm/subdev/bios/volt.c
    @@ -40,8 +40,10 @@ nvbios_volt_table(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len)
                    if (volt) {
                            *ver = nvbios_rd08(bios, volt + 0);
    +                       printk ("nvbios_volt_table_Ver, %d\n", *ver);
                            switch (*ver) {
                            case 0x12:
    +                       case 0x10:
                                    *hdr = 5;
                                    *cnt = nvbios_rd08(bios, volt + 2);
                                    *len = nvbios_rd08(bios, volt + 1);
    @@ -71,8 +73,11 @@ nvbios_volt_parse(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len,
            u16 volt = nvbios_volt_table(bios, ver, hdr, cnt, len);
            memset(info, 0x00, sizeof(*info));
    +       printk("nvbios_volt_parse called!\n");
    +       printk("volt_table_Version: %d\n", !!volt * *ver);
            switch (!!volt * *ver) {
            case 0x12:
    +       case 0x10:
                    info->type    = NVBIOS_VOLT_GPIO;
                    info->vidmask = nvbios_rd08(bios, volt + 0x04);
    @@ -131,8 +136,10 @@ nvbios_volt_entry_parse(struct nvkm_bios *bios, int idx, u8 *ver, u8 *len,
            u16 volt = nvbios_volt_entry(bios, idx, ver, len);
            memset(info, 0x00, sizeof(*info));
    +       printk("nvbios_volt_entry_parse called!\n");
            switch (!!volt * *ver) {
            case 0x12:
    +       case 0x10:
            case 0x20:
                    info->voltage = nvbios_rd08(bios, volt + 0x00) * 10000;
                    info->vid     = nvbios_rd08(bios, volt + 0x01);

and it seems to work.
Comment 1 Andrew Randrianasulu 2015-10-10 05:12:18 UTC
Created attachment 118792 [details]
vbios  as extracted by envytools, try 2
Comment 2 Martin Peres 2019-12-04 09:04:57 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/driver/xf86-video-nouveau/issues/223.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.