Bug 92848

Summary: xlib & xcb mix may lead to shmdt before Attach
Product: cairo Reporter: Marc-Andre Lureau <marcandre.lureau>
Component: xlib backendAssignee: Chris Wilson <chris>
Status: RESOLVED FIXED QA Contact: cairo-bugs mailing list <cairo-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: fix

Description Marc-Andre Lureau 2015-11-06 17:25:06 UTC
Created attachment 119449 [details]
fix

See attached patch
Comment 1 Uli Schlachter 2015-11-06 20:02:53 UTC
commit 98d01cd119eaa7d50cf0ec6c6cc32ee170397ad5
Author: Marc-André Lureau <marcandre.lureau@gmail.com>
Date:   Fri Nov 6 18:13:05 2015 +0100

    xlib: fix mixing xcb & xlib calls
    
    NextRequest is a macro that doesn't mix well with xcb, since
    dpy->request is not updated. Instead use XNextRequest() that was fixed
    to do the right thing with xcb in libX11 commit:
    http://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=7f8f9a36ef901f31279c385caf960a22daeb33fe
    
    This may solve application X errors when a shmdt() is called by cairo
    before the Attach request is processed.
    
    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Signed-off-by: Uli Schlachter <psychon@znc.in>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.