Bug 93191

Summary: xorg-gtest CPPflags string aren't properly quoted with new pkg-config
Product: xorg Reporter: Marco Trevisan (Treviño) <mail>
Component: * OtherAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED MOVED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
xorg-gtest.pc.in-Fix-CPPflags-escaping-for-string-pa.patch none

Description Marco Trevisan (Treviño) 2015-12-01 09:48:05 UTC 
Created attachment 120222 [details]
xorg-gtest.pc.in-Fix-CPPflags-escaping-for-string-pa.patch

As per the pkg-config fix for Bug 67904, xorg-gtest CPPflags aren't properly escaped anymore.

old_behavior $ pkg-config --variable=CPPflags xorg-gtest 
-I/usr/include -I/usr/include/xorg -I/usr/src/xorg-gtest -DDUMMY_CONF_PATH=\"/usr/share/xorg/gtest/dummy.conf\" -DLOGFILE_DIR=\"/tmp\"


new_behavior $ pkg-config --variable=CPPflags xorg-gtest 
-I/usr/include -I/usr/include/xorg -I/usr/src/xorg-gtest -DDUMMY_CONF_PATH=/usr/share/xorg/gtest/dummy.conf -DLOGFILE_DIR=/tmp

Attached is a patch that fixes this
Comment 1 GitLab Migration User 2019-05-23 18:41:53 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/test/xorg-gtest/issues/2.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.