Bug 93211

Summary:	Build broken for uClibc
Product:	p11-glue	Reporter:	Gustavo Zacarias <gustavo>
Component:	p11-kit	Assignee:	Stef Walter <stefw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Include sys/select.h in rpc_transport.c for *nixes

Description Gustavo Zacarias 2015-12-02 10:23:27 UTC

Created attachment 120273 [details] [review]
Include sys/select.h in rpc_transport.c for *nixes

fd_set and friends are defined in sys/select.h according to POSIX.1-2001
Since it's not included this breaks "pure" libc implementations like uClibc when building:

p11-kit/rpc-transport.c: In function ‘rpc_socket_read’:
p11-kit/rpc-transport.c:350:2: error: unknown type name ‘fd_set’
p11-kit/rpc-transport.c:416:4: warning: implicit declaration of function ‘FD_ZERO’ [-Wimplicit-function-declaration]
p11-kit/rpc-transport.c:416:4: warning: nested extern declaration of ‘FD_ZERO’ [-Wnested-externs]
p11-kit/rpc-transport.c:417:4: warning: implicit declaration of function ‘FD_SET’ [-Wimplicit-function-declaration]
p11-kit/rpc-transport.c:417:4: warning: nested extern declaration of ‘FD_SET’ [-Wnested-externs]
p11-kit/rpc-transport.c:418:4: warning: implicit declaration of function ‘select’ [-Wimplicit-function-declaration]
p11-kit/rpc-transport.c:418:4: warning: nested extern declaration of ‘select’ [-Wnested-externs]
Makefile:2773: recipe for target 'p11-kit/libp11_kit_testable_la-rpc-transport.lo' failed
make[3]: *** [p11-kit/libp11_kit_testable_la-rpc-transport.lo] Error 1

Comment 1 Stef Walter 2015-12-08 11:31:58 UTC

Thanks. Merged and included in release 0.23.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.