Bug 93235

Summary: [regression] dispatch sanity broken by GetPointerv
Product: Mesa Reporter: Mark Janes <mark.a.janes>
Component: Drivers/DRI/i965Assignee: Emil Velikov <emil.l.velikov>
Status: CLOSED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium CC: mark.a.janes, t_arceri
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Mark Janes 2015-12-03 21:30:52 UTC
f53f9eb8d495a318bc8e6fd758df4ba4074599ef broke dispatch sanity on GLES2,3, and 3.1

/mnt/space/jenkins/jobs/Leeroy/workspace@3/repos/mesa/src/mesa/main/tests/dispatch_sanity.cpp:173
Value of: table[i]
  Actual: 0x4472b0
Expected: nop_table[i]
Which is: 0x415dc0
i = 329 (GetPointerv)


Author:     Emil Velikov <emil.l.velikov@gmail.com>
AuthorDate: Thu Nov 26 00:36:10 2015 +0000
Commit:     Emil Velikov <emil.l.velikov@gmail.com>
CommitDate: Thu Dec 3 19:17:48 2015 +0000

    glapi: add GetPointervKHR to the ES dispatch
    
    The KHR_debug extension implements this.
    
    Strictly speaking it could be used with ES 1.0, although as the original
    function is available on ES 1.1, I'm inclined to lift the KHR_debug
    requirement to ES 1.1.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93048
    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
    Reviewed-by: Timothy Arceri <timothy.arceri@collabora.com>
Comment 1 Emil Velikov 2015-12-03 22:01:37 UTC
The following patch fixes the problem on my end
http://patchwork.freedesktop.org/patch/67060/
Comment 2 Emil Velikov 2015-12-04 14:38:18 UTC
A fix has landed in master. Sorry for the breakage and thanks for the prompt report.

commit 1074e38fbbc89a06c74f036622cbe2778bee993a
Author: Emil Velikov <emil.l.velikov@gmail.com>
Date:   Thu Dec 3 22:01:31 2015 +0000

    mesa/tests: add KHR_debug GLES glGetPointervKHR entry points

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.