| Summary: | unistd.h not available on every platform | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Christian Ehrlicher <ch.ehrlicher> |
| Component: | core | Assignee: | Havoc Pennington <hp> |
| Status: | RESOLVED FIXED | QA Contact: | John (J5) Palmieri <johnp> |
| Severity: | trivial | ||
| Priority: | high | ||
| Version: | unspecified | ||
| Hardware: | x86 (IA32) | ||
| OS: | Windows (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | add configure test for unistd.h | ||
|
Description
Christian Ehrlicher
2006-12-13 06:07:56 UTC
Created attachment 8101 [details] [review] add configure test for unistd.h Shouldn't the patch also add some #ifdef HAVE_UNISTD_H ? This seems like a file that would be wrong to use outside of a -unix.c file perhaps Appended is a patch for the related case Index: test/name-test/test-names.c =================================================================== --- test/name-test/test-names.c (Revision 543) +++ test/name-test/test-names.c (Arbeitskopie) @@ -1,9 +1,11 @@ #include <stdio.h> #include <stdlib.h> -#include <unistd.h> #include <string.h> #include <dbus/dbus.h> #include <dbus/dbus-connection-internal.h> +#ifdef HAVE_UNISTD_H +#include <unistd.h> +#endif #define REMOVE_CONNECTION 0 #define ADD_CONNECTION 1 does test-names.c really need unistd.h? if the file builds without it maybe it's just a bogus include The patch appears to have gone in back in March; closing. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.