Bug 93384

Summary: [SKL] DDX fails to do native 90/270 rotation
Product: DRI Reporter: Tvrtko Ursulin <tvrtko.ursulin>
Component: DRM/IntelAssignee: Intel GFX Bugs mailing list <intel-gfx-bugs>
Status: CLOSED WONTFIX QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: intel-gfx-bugs
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: SKL i915 features: display/Other
Attachments:
Description Flags
Default DDX build
none
Y-tiled scanout DDX build
none
hack for Y tiling and rotation none

Description Tvrtko Ursulin 2015-12-15 11:05:31 UTC
Created attachment 120521 [details]
Default DDX build

Neither DDX default build, or when built to default to Y tiled scanout, manage to do the hardware 90/270 rotation. Instead it falls back to software rotation and X tiled fb.

Allegedly kernel rejects the setcrtc call DDX makes so perhaps the DDX is not respecting some of the kernel rules on how this should be used.

I got some old Xorg log for both build flavours showing this which I'll attach.
Comment 1 Tvrtko Ursulin 2015-12-15 11:05:54 UTC
Created attachment 120522 [details]
Y-tiled scanout DDX build
Comment 2 Chris Wilson 2015-12-15 11:07:57 UTC
But it is hardware accelerated. Be more specific.
Comment 3 Chris Wilson 2015-12-15 11:10:08 UTC
Kernel still rejects it.
Comment 4 Chris Wilson 2015-12-15 17:28:44 UTC
So I added

commit f458e8c41112cf56a132ac42cc9e6a4be893ff2c
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Dec 15 16:46:47 2015 +0000

    sna: Dump kernel debug messages for KMS failures

to capture the kernel debug messages upon setcrtc failure (requires a full-debug build).
Comment 5 Ville Syrjala 2016-01-19 18:26:40 UTC
Created attachment 121141 [details] [review]
hack for Y tiling and rotation

This is my hack to get the ddx to do 90/270 rotated scanout.
Comment 6 Ville Syrjala 2016-05-11 14:06:06 UTC
Also need this kernel patch:
https://lists.freedesktop.org/archives/dri-devel/2016-January/098828.html
Comment 7 yann 2016-05-25 08:30:19 UTC
Tvrtko, can you re-test with Ville recommendation?
thanks
Comment 8 Tvrtko Ursulin 2016-05-27 09:13:34 UTC
Unfortunately not, I don't have the suitable hardware any more.
Comment 9 Ricardo 2017-02-21 16:29:31 UTC
This issues is no longer reproducible lack of hardware, please if the issue appears open a new bug

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.