Bug 93442

Summary: xdg-open: open_mate (and others), consider adding open_generic fallback, remove references to deprecated mate-open
Product: Portland Reporter: jylo06g
Component: xdg-utilsAssignee: Portland Bugs <portland-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: chat-to-me
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description jylo06g 2015-12-18 15:57:51 UTC
https://github.com/mate-desktop/mate-desktop/issues/212

As described in link above,
the MATE team claimed that they already dropped mate-open a long time ago.

So time for a cleanup perhaps?
Comment 1 Rex Dieter 2015-12-18 16:03:23 UTC
gvfs-open is (still) preferred on mate, mate-open is kept only as a compatibility fallback.
Comment 2 Wolfgang Ulbrich 2015-12-18 16:10:15 UTC
(In reply to Rex Dieter from comment #1)
> gvfs-open is (still) preferred on mate, mate-open is kept only as a
> compatibility fallback.

Yes, but we have no command /usr/bin/mate-open anymore.
Comment 3 Rex Dieter 2015-12-18 17:02:03 UTC
Yes, I know that.

I'm saying it (xdg-open) should never get that far, because it'll use gvfs-open instead (if it exists, which it should)
Comment 4 jylo06g 2015-12-19 02:30:01 UTC
See comment#0
Apparently some Steam Python game manages to bypass or game/Python 2.7 glitch(?) through the check mechanism and ended up at mate-open.

Back to the report, what I am going to report here is that

it is time to change the "obsolete" mate-open to another fallback alternative.

and

NOT to argue why is the check mechanism is not working or why the game is not properly configured.

What's the point of still having a "non-existing" command in xdg-open as compatibility?

Can't we just follow LXDE (non-gnome example) using open_generic as fallback?
Comment 5 Rex Dieter 2015-12-19 13:53:06 UTC
We certainly can add a fallback to use generic methods

But imo, it'll only be a bandaid for a gaping wound: any mate environment that doesn't include gvfs-open is going to have a degraded experience no matter what we do here to mitigate it.
Comment 6 Rex Dieter 2015-12-19 13:55:09 UTC
adjusting summary
Comment 7 Rex Dieter 2015-12-19 17:10:16 UTC
http://cgit.freedesktop.org/xdg/xdg-utils/commit/?id=abd6cef36874f73c5c1c4a734d83eba9d340afe4

Please let us know if you need anything else.
Comment 8 jylo06g 2015-12-20 02:21:17 UTC
Ok thanks!

I guess it's Steam improper configuration all along after doing some further test...
(will report that later after I contacted the game developer)

I guess I can also rationalize your stand to keep mate-open for older MATE DE versions...
(but sooner or later have to drop it altogether though and even then I don't think old version of distro will ship this update)

But mind if I ask why is it

+ elif mate-open --help >/dev/null 2>&1; then

and not

+ elif mate-open --help 2>/dev/null 1>&2; then

like how the other *-open commands used?
Comment 9 Rex Dieter 2015-12-20 02:50:05 UTC
Good catch.

Prior to my latest commit, xdg-open had an inconsistent hodge-podge:

$ grep null xdg-open.in 
    if gvfs-open --help >/dev/null 2>&1; then
    if gvfs-open --help >/dev/null 2>&1; then
    elif gnome-open --help >/dev/null 2>&1; then
    if gvfs-open --help 2>/dev/null 1>&2; then
        command_exec=`which $command 2>/dev/null`
        if which run-mailcap 2>/dev/null 1>&2; then
        if has_display && mimeopen -v 2>/dev/null 1>&2; then

I suppose we can standardize on the 2>/dev/null 1>&2 variant, sure (fixed in followup commit)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.