| Summary: | radeonsi vaapi mpeg2 decode slightly corrupt or asserts. | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Andy Furniss <adf.lists> |
| Component: | Drivers/Gallium/radeonsi | Assignee: | mesa-dev |
| Status: | RESOLVED MOVED | QA Contact: | mesa-dev |
| Severity: | normal | ||
| Priority: | medium | CC: | aklhfex |
| Version: | git | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
assert
lock hung task trace |
||
|
Description
Andy Furniss
2016-01-18 16:41:56 UTC
Created attachment 121115 [details]
lock hung task trace
Time moves on - I can't actually lock (so far) testing now, but output is still corrupt. Sorry totally missed that bug. The problem is most likely that GStreamer sends multiple slices in one request to VA-API and we can't handle that in the state tracker. Should be easy to fix actually, but we need somebody to look into it and reproduce this. Another task for Nayan maybe? I can reproduce the issue. I will look more into this over the weekend and also read more about VA-API. (In reply to Christian König from comment #3) > Sorry totally missed that bug. > > The problem is most likely that GStreamer sends multiple slices in one > request to VA-API and we can't handle that in the state tracker. Though it seems gstreamer also has issues, I only first tried it today. This bug is testing with mpv. (In reply to Christian König from comment #3) > Sorry totally missed that bug. > > The problem is most likely that GStreamer sends multiple slices in one > request to VA-API and we can't handle that in the state tracker. > > Should be easy to fix actually, but we need somebody to look into it and > reproduce this. > What changes do we need to make to handle multiple slices? The video plays fine with vdpau. Can you point me to the code where vdpau handles multiple slices as both of them share similar code path. > Another task for Nayan maybe? Take a look at vlVaHandleSliceParameterBufferMPEG12 and the assert. We probably just need to handle the case of multiple buffers here and in handleVASliceDataBufferType. The later is a bit tricky, since you need to search all slice buffers for the start code and call begin_frame() only once even when you get multiple buffers and/or calls to that function. (In reply to Christian König from comment #7) > Take a look at vlVaHandleSliceParameterBufferMPEG12 and the assert. > > We probably just need to handle the case of multiple buffers here and in > handleVASliceDataBufferType. > > The later is a bit tricky, since you need to search all slice buffers for > the start code and call begin_frame() only once even when you get multiple > buffers and/or calls to that function. mpv only send a single slice when it should be sending 36 which it does in case of VDPAU, as of now we can handle multiple slices, though not as efficiently as we like it to be. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/1227. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.