| Summary: | call-stream: fix missing network proto | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Fabrice Bellet <fabrice> |
| Component: | tp-farstream | Assignee: | Olivier Crête <olivier.crete> |
| Status: | RESOLVED MOVED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
call-stream: fix missing network proto
call-stream: ignore local candidates with TCP proto |
||
TCP-Active can'T be treated as TCP/TCP-PAssive.. Until the telepathy spec is updated to support ICE-TCP correctly, they should just be dropped. The problem with the current implementation is that these TCP candidates are not dropped, they are passed to telepathy as UDP candidates, and transmitted to the peer agent as such. This causes the creation of a significant number of pairs with UDP remote candidates having a destination port of "0". Connchecks on these pairs never hit the wire, but they waste ressources, specifically in the computation of conncheck timeout of all other pairs, that takes into account the number of in-progress pairs. If these candidates are passed to telepathy as TCP, they are dropped by telepathy-gabble (wocky-jingle-transport-iceudp.c) Yes, I think you should just patch it to drop TCP candidates entirely until the Telepathy spec is update to have the three different kinds of TCP candidates (active, passive and s/o). Created attachment 122879 [details] [review] call-stream: ignore local candidates with TCP proto This is a new version of the patch that doesn't transmit TCP local candidates to Telepathy instead of tweaking the network proto. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-farstream/issues/5. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 121474 [details] call-stream: fix missing network proto This patch fixes a bug where FS_NETWORK_PROTOCOL_TCP_ACTIVE protocol is not recognized. In this case, tp-farstream falls back to an UDP protocol, causing the addition of more UDP candidates than strictly needed.