| Summary: | [BAT regression] snd-hda blows up in module reload since CI build 1040 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | Daniel Vetter <daniel> | ||||
| Component: | DRM/Intel | Assignee: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||
| Severity: | blocker | ||||||
| Priority: | highest | CC: | intel-gfx-bugs | ||||
| Version: | XOrg git | ||||||
| Hardware: | Other | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| i915 platform: | HSW | i915 features: | display/audio | ||||
| Attachments: |
|
||||||
|
Description
Daniel Vetter
2016-02-10 16:27:26 UTC
Around the same time also a bunch of machines started dying, but that might be an unrelated regression. The bisect done on HSW lead to: commit 25e4abb33df3aafa7d1efba8f82f9178268efab1 Author: Libin Yang <libin.yang@linux.intel.com> Date: Tue Jan 12 11:13:27 2016 +0800 ALSA: hda - hdmi jack created based on pcm Jack is created based on pcm. Apply the acomp jack rule to dyn_pcm_assign. For dyn_pcm_assign: Driver does not use hda_jack. It operates snd_jack directly. snd_jack pointer will be stored in spec->pcm.jack instead of the current spec->acomp_jack. When pcm is assigned to pin, jack will be assigned to pin automatically. For !dyn_pcm_assign: Driver continues using hda_jack for less impact on the old cases. Pcm is statically assigned to pin. So is jack. spec->pcm.jack saves the snd_jack pointer created in hda_jack. Signed-off-by: Libin Yang <libin.yang@linux.intel.com> Signed-off-by: Takashi Iwai <tiwai@suse.de> I have made a patch for it. The patch can fix the issue. I'm refining the patch now and QA is helping test. Could you please send us your test case? So we can do the test on our side. Patch is merged into Takashi's branch. tests/drv_module_reload_basic passed with this patch. Do gfx QA need to do a test before merging Takashi's branch or let's merge Takashi's branch first and gfx QA do the test? Created attachment 121838 [details]
Patch for latest takashi's branch
The patch had been merged into Takashi's branch(ALSA tree), but it is still not merged into the drm-intel-nightly tree. Libin also have pinged Daniel Vetter to merge this patch from ALSA tree. Now, just to wait Daniel to merge up this patch to drm-intel-nightly tree. Could you please help merge Takashi's branch and to see if it is OK now? Test is Pass. I don't see any RIP or audio problem in kern.log. Hardware: Motherboard: SawTooth Peak cpu model name : Intel(R) Core(TM) i7-4550U CPU @ 1.50GHz cpu model : 69 cpu family : 6 Graphic card: Haswell-ULT Integrated Graphics Controller (rev 09) Software: Ubuntu 14.04.4 LTS Bios: HSWLPTU1.86C.0135.R01.1311020052 Libdrm: 2.4.64 Kernel 4.5.0-rc6 drm-intel-nightly from git://anongit.freedesktop.org/drm-intel commit f9cadb616ff17d482312fba07db772b6604ce799 Author: Imre Deak <imre.deak@intel.com> Date: Tue Mar 1 19:17:18 2016 +0200 drm-intel-nightly: 2016y-03m-01d-17h-16m-32s UTC integration manifest So closed |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.