Bug 94083

Summary: Transaction ID rollover at 0xff
Product: libqmi Reporter: John <jearleal>
Component: libqmiAssignee: Dan Williams <dcbw>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: medium    
Version: unspecified   
Hardware: PowerPC   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description John 2016-02-10 20:42:55 UTC
The template used in Message.py incorrectly creates a transaction id var as a guint8 when it should be a guint16 on line 97:

            '    guint8 transaction_id,\n'

This has the effect of causing all transaction IDs in the generated code to rollover at 8 bit boundary.
Comment 1 Dan Williams 2016-02-10 21:36:36 UTC
Thanks, fix pushed to master, 1-12, and 1-10.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.