Bug 94140

Summary: [regression, HSW, IVB] piglit.spec.arb_shader_image_load_store.max-images
Product: Mesa Reporter: Mark Janes <mark.a.janes>
Component: Drivers/DRI/i965Assignee: Ilia Mirkin <imirkin>
Status: CLOSED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium CC: jljusten, maraeo, samuel.pitoiset
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Mark Janes 2016-02-13 21:36:43 UTC 
This test began failing on linux 4.4 haswell & ivybridge at:

f2547883cfcc7c7629e09cb38c162ad7f5d77611
Author:     Ilia Mirkin <imirkin@alum.mit.edu>
mesa: make compute maximums reflect driver-provided values

Looks like the various max's were never plumbed through.

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>

Standard Output:
/tmp/build_root/m64/lib/piglit/bin/arb_shader_image_load_store-max-images -auto -fbo
piglit: debug: Requested an OpenGL 3.2 Core Context, and received a matching 3.3 context

Standard Error:
Failed to link: error: Too many compute shader image uniforms (35002 > 32)
error: Too many combined image uniforms
error: Too many combined image uniforms, shader storage  buffers and fragment outputs
Comment 1 Ilia Mirkin 2016-02-13 21:54:28 UTC 
I looked over the commit and don't see anything obviously wrong. I won't have access to a HSW box to debug this until Tuesday or so... sorry. I'm suspecting this is a bug in the test rather than a bug in the commit.
Comment 2 Kenneth Graunke 2016-02-14 01:26:49 UTC 
Yep, that patch is fine.  It causes us to (correctly) advertise 32 instead of 8, which has both exposed a bug in the linker and a bug in the test.  I fixed one, curro fixed the other.  We'll send patches soon...
Comment 3 Kenneth Graunke 2016-02-14 01:28:23 UTC 
Linker patch: https://lists.freedesktop.org/archives/mesa-dev/2016-February/107615.html
Comment 4 Francisco Jerez 2016-02-14 01:38:05 UTC 
Piglit fix pushed as 3957dd34102bf60cb738596e2a5551b6a4858c8f.  The bug should no longer be reproducible with latest master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.