| Summary: | weston (1.9.92-master): fails to build RDP compositor | ||
|---|---|---|---|
| Product: | Wayland | Reporter: | Hector Oron <hector.oron> |
| Component: | weston | Assignee: | Wayland bug list <wayland-bugs> |
| Status: | RESOLVED NOTABUG | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Newer FreeRDP required: https://github.com/FreeRDP/FreeRDP/tree/2ac195e8eb2c5fbbe8f2abeac92b0c8effef0e34 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
When enabling RDP compositor build: libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./src -I./src -I./clients -I./tests -I./shared -I./protocol -DDATADIR=\"/usr/share\" -DMODULEDIR=\"/usr/lib/i386-linux-gnu/weston\" -DLIBEXECDIR=\"/usr/lib/weston\" -DBINDIR=\"/usr/bin\" -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/pixman-1 -I/usr/include/i386-linux-gnu -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g -fvisibility=hidden -Wstrict-prototypes -Wmissing-prototypes -Wsign-compare -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c src/compositor-rdp.c -fPIC -DPIC -o src/.libs/rdp_backend_la-compositor-rdp.o src/compositor-rdp.c: In function ‘rdp_peer_init’: src/compositor-rdp.c:1151:10: error: ‘rdpSettings {aka struct rdp_settings}’ has no member named ‘SurfaceFrameMarkerEnabled’ settings->SurfaceFrameMarkerEnabled = TRUE; ^ Makefile:4682: recipe for target 'src/rdp_backend_la-compositor-rdp.lo' failed make[2]: *** [src/rdp_backend_la-compositor-rdp.lo] Error 1 SurfaceFrameMarkerEnabled does not seem to be a member of RDP settings struct. Do you really mean SurfaceCommandsEnabled? The following patch (which I am unsure if it is correct) fixes the issue: --- a/src/compositor-rdp.c +++ b/src/compositor-rdp.c @@ -1148,7 +1148,7 @@ rdp_peer_init(freerdp_peer *client, struct rdp_backend *b) settings->RemoteFxCodec = TRUE; settings->NSCodec = TRUE; settings->FrameMarkerCommandEnabled = TRUE; - settings->SurfaceFrameMarkerEnabled = TRUE; + settings->SurfaceCommandsEnabled = TRUE; client->Capabilities = xf_peer_capabilities; client->PostConnect = xf_peer_post_connect;