Bug 94276

Summary:	Use CSS-based rendering for virt-viewer
Product:	Spice	Reporter:	Fabiano Fidêncio <fabiano>
Component:	virt-viewer	Assignee:	Spice Bug List <spice-bugs>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	medium	CC:	pavelgrunt
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch

Description Fabiano Fidêncio 2016-02-24 07:59:01 UTC

virt-viewer makes use of a few functions that are deprecated on GTK 3.16, like gtk_widget_background_color() and gtk_widget_override_background_color().

Would be good to provide/write a "custom style provider" and replace those deprecated functions as soon as possible.

Comment 1 Eduardo Lima (Etrunko) 2016-06-27 17:32:55 UTC

Created attachment 124743 [details] [review]
Patch

Comment 2 Fabiano Fidêncio 2016-06-27 17:43:31 UTC

(In reply to Eduardo Lima (Etrunko) from comment #1)
> Created attachment 124743 [details] [review] [review]
> Patch

Etrunko, could you please drop the patch to the virt-tools ML?
Also, from a quick review I wouldn't use gtk_check_version() but use #if ! GTK_VERSION(3,20,0) instead ...

Comment 3 Fabiano Fidêncio 2016-06-27 17:47:55 UTC

(In reply to Fabiano Fidêncio from comment #2)
> (In reply to Eduardo Lima (Etrunko) from comment #1)
> > Created attachment 124743 [details] [review] [review] [review]
> > Patch
> 
> Etrunko, could you please drop the patch to the virt-tools ML?
> Also, from a quick review I wouldn't use gtk_check_version() but use #if !
> GTK_VERSION(3,20,0) instead ...

s/GTK_VERSION/GTK_CHECK_VERSION

Comment 4 Pavel Grunt 2016-06-30 12:57:49 UTC

the deprecated functions were dropped, no need to use css for virt-viewer

https://git.fedorahosted.org/cgit/virt-viewer.git/commit/?id=8a32e0bfee80378106adb9b3cddfd087a4371859

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.