| Summary: | [configure] --with-macbookpro autodetection broken / build break | ||
|---|---|---|---|
| Product: | hal | Reporter: | Stef van der Made <svandermade> |
| Component: | build | Assignee: | David Zeuthen (not reading bugmail) <zeuthen> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | high | CC: | guenther, svandermade |
| Version: | unspecified | ||
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | proposed fix | ||
Running into the same issue here, hal-0.5.8.1.
The mention auto-detection of Macbook Pro obviously fails. Also, neither
--without-macbookpro nor --with-macbookpro=no do help. Configure results always
include these lines, regardless of the options:
use libpci: no
build Macbook Pro utils: yes
A related issue is, that the Macbook Pro utils should not be enabled anyway, if
libpci is not available.
I have the same issue. the .configure script always gives back build "Macbook Pro utils: yes" while I say --with-macbookpro=no or --without-macbookpro The source of the problem is a misnamed variable in configure.in The fix is simple: replace: use_macbookpro -> with_macbookpro -Joseph I tried using both options of --with-macbookpro=no or --without-macbookpro and the comment 3 idea and for some reason it is still not working. Created attachment 8390 [details] [review] proposed fix The above patch seems to fix this issue for me, after running some quick tests. Additionally to the already mentioned use_macbookpro oops, usage of HAVE_LIBPCI seems to be false, too. libpci presence is now correctly tested as a condition whether the Macbook Pro utils actually *can* be built or not. Adjusting Summary. Severity major, since this breaks the build. I can confirm the fix for hal-0.5.8.1 This is already fixed in git. Close this bug now |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
While compiling hal I get the following error in my compiler: then mv -f ".deps/addon-macbookpro-backlight.Tpo" ".deps/addon-macbookpro-backlight.Po"; else rm -f ".deps/addon-macbookpro-backlight.Tpo"; exit 1; fi addon-macbookpro-backlight.c:36:21: error: pci/pci.h: No such file or directory addon-macbookpro-backlight.c: In function 'filter_function': addon-macbookpro-backlight.c:311: warning: initialization from incompatible pointer type addon-macbookpro-backlight.c: In function 'main': addon-macbookpro-backlight.c:441: warning: implicit declaration of function 'pci_alloc' addon-macbookpro-backlight.c:441: warning: nested extern declaration of 'pci_alloc' addon-macbookpro-backlight.c:441: warning: initialization makes pointer from integer without a cast addon-macbookpro-backlight.c:442: warning: implicit declaration of function 'pci_init' addon-macbookpro-backlight.c:442: warning: nested extern declaration of 'pci_init' addon-macbookpro-backlight.c:443: warning: implicit declaration of function 'pci_scan_bus' addon-macbookpro-backlight.c:443: warning: nested extern declaration of 'pci_scan_bus' addon-macbookpro-backlight.c:445: error: dereferencing pointer to incomplete type addon-macbookpro-backlight.c:445: error: dereferencing pointer to incomplete type addon-macbookpro-backlight.c:446: warning: implicit declaration of function 'pci_fill_info' addon-macbookpro-backlight.c:446: warning: nested extern declaration of 'pci_fill_info' addon-macbookpro-backlight.c:446: error: 'PCI_FILL_IDENT' undeclared (first use in this function) addon-macbookpro-backlight.c:446: error: (Each undeclared identifier is reported only once addon-macbookpro-backlight.c:446: error: for each function it appears in.) addon-macbookpro-backlight.c:446: error: 'PCI_FILL_BASES' undeclared (first use in this function) addon-macbookpro-backlight.c:447: error: dereferencing pointer to incomplete type addon-macbookpro-backlight.c:447: error: dereferencing pointer to incomplete type addon-macbookpro-backlight.c:448: error: dereferencing pointer to incomplete type addon-macbookpro-backlight.c:449: error: dereferencing pointer to incomplete type addon-macbookpro-backlight.c:452: warning: implicit declaration of function 'pci_cleanup' addon-macbookpro-backlight.c:452: warning: nested extern declaration of 'pci_cleanup' make[6]: *** [addon-macbookpro-backlight.o] Error 1 make[6]: Leaving directory `/usr/download/garnome-2.17.4/freedesktop/hal/work/main.d/hal-0.5.8.1/hald/linux/addons' make[5]: *** [all-recursive] Error 1 make[5]: Leaving directory `/usr/download/garnome-2.17.4/freedesktop/hal/work/main.d/hal-0.5.8.1/hald/linux' make[4]: *** [all-recursive] Error 1 make[4]: Leaving directory `/usr/download/garnome-2.17.4/freedesktop/hal/work/main.d/hal-0.5.8.1/hald' make[3]: *** [all] Error 2 make[3]: Leaving directory `/usr/download/garnome-2.17.4/freedesktop/hal/work/main.d/hal-0.5.8.1/hald' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/usr/download/garnome-2.17.4/freedesktop/hal/work/main.d/hal-0.5.8.1' make[1]: *** [all] Error 2 make[1]: Leaving directory `/usr/download/garnome-2.17.4/freedesktop/hal/work/main.d/hal-0.5.8.1' make: *** [build-work/main.d/hal-0.5.8.1/Makefile] Error 2 I'm running gcc-4.1.1, kernel-headers and sources 2.6.18. The issue looks similar to bug 7176 but the fix in that bug doesn't help resolve the issue