| Summary: | Cairo should support font-backend-specific reference images. | ||
|---|---|---|---|
| Product: | cairo | Reporter: | Brian Ewins <Brian.Ewins> |
| Component: | general | Assignee: | Carl Worth <cworth> |
| Status: | RESOLVED FIXED | QA Contact: | cairo-bugs mailing list <cairo-bugs> |
| Severity: | normal | ||
| Priority: | high | ||
| Version: | 1.3.9 | ||
| Hardware: | PowerPC | ||
| OS: | Mac OS X (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Enables backends-specific reference images | ||
|
Description
Brian Ewins
2006-12-28 05:52:32 UTC
Created attachment 8232 [details] [review] Enables backends-specific reference images I made what seemed like the simplest change, a compile-time check. It introduces a new element to test case names in front of the target, eg: dummy-atsui-image-argb32-ref.png would be a valid reference image for 'dummy'. Backend-specific reference images are tested for first. Random comments on the patch: 1) I prefer finding the font backend using cairo_font_type_t. For example using cairo_get_font_face() + cairo_font_face_get_type(). Unfortunately this probably doesn't work. It probably returns CAIRO_FONT_TYPE_TOY. We need cairo_get_scaled_font() API first. 2) Please call font backends "font-backend", not "backend". 3) We probably should do something more clever now that the involved parameters are increasing. Marking tests as having text is probably one thing we want to do. Behdad's comments are all good. In addition I'd definitely consider the "font backend" to be secondary to the "surface backend", (rather erroneously named "target" in the current test code). So I'd rather see "image-atsui" than "atsui-image". But, yes, as Behdad hints, this whole thing is a mess and could use some re-architecting before we add too many more bandaids. -Carl Moved to the test-suite section of the TODO. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.