Bug 94881

Summary: Build failure in GNOME Continuous
Product: libmbim Reporter: Emmanuele Bassi (:ebassi) <ebassi>
Component: GeneralAssignee: Aleksander Morgado <aleksander>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Emmanuele Bassi (:ebassi) 2016-04-10 12:39:23 UTC
The build of libmbim fails since commit 82b7cd5013bcff0c05dd91e6a7f9bbfbf3e53d0d because the gudev CFLAGS and LIBS are not used anywhere when building libmbim-glib.

../../../src/libmbim-glib/mbim-device.c:43:26: fatal error: gudev/gudev.h: No such file or directory
 # include <gudev/gudev.h>
                          ^
compilation terminated.
Makefile:611: recipe for target 'libmbim_glib_core_la-mbim-device.lo' failed

The gudev-1.0 dependency has been moved out of LIBMBIM_GLIB_CFLAGS and LIBMBIM_GLIB_LIBS, which means that you need to add GUDEV_CFLAGS and GUDEV_LIBS to the libmbim_glib_core_la_CPPFLAGS and libmbim_glib_la_LIBADD targets.

Additionally, you make want to add a conditional `Requires.private: gudev-1.0` to the pkg-config file, as the dependency to gudev-1.0 is still needed, only not exposed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.