Bug 94946

Summary: xdg-mime: not working with kde-cli-tools-5.6 due to changed output format of ktraderclient5
Product: Portland Reporter: Massimiliano Torromeo <massimiliano.torromeo>
Component: xdg-utilsAssignee: Portland Bugs <portland-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: massimiliano.torromeo
Version: 1.1.0   
Hardware: Other   
OS: All   
i915 platform: i915 features:

Description Massimiliano Torromeo 2016-04-15 09:31:18 UTC
KDE Frameworks 5.6 changed the output format of ktraderclient5 tool.

The output of the command "/usr/bin/ktraderclient5 --mimetype text/html --servicetype Application" changed from [1] to [2]

I implemented a possible fix [3] which processes both style of outputs.


[1] http://pastebin.com/g8mWZT3j
[2] http://pastebin.com/sc7xSYsp
[3] https://github.com/mtorromeo/xdg-utils/commit/13dc2b719b37e867ee37c4beb8c9b55451d1d046
Comment 1 Rex Dieter 2016-04-15 13:06:03 UTC
that incompatible ktraderclient5 change was reverted,


I suppose we could consider adjusting xdg-mime to handle both cases, does your patch do that?
Comment 2 Massimiliano Torromeo 2016-04-15 13:33:30 UTC
Yes, my patch would handle both extended and short output correctly.

I've actually updated the patch [1] to make it more robust and avoid possible wrong matches on weird comments or other properties.

Note that these wrong matches were still possible even without my patch.

[1] https://github.com/mtorromeo/xdg-utils/commit/86189ab62bf18ad8547ef7e56fe55d10b0a9dee3
Comment 3 Rex Dieter 2016-04-15 13:36:41 UTC
OK, though I usually prefer that separate issues be fixed by separate commits for more clarity, we can make an exception here
Comment 4 Rex Dieter 2016-04-15 13:44:26 UTC
committed, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.