Bug 94950

Summary: [spice-gtk] flickering wayland guest
Product: Spice Reporter: Joachim Frieben <jfrieben>
Component: spice-gtkAssignee: Spice Bug List <spice-bugs>
Status: RESOLVED MOVED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch for spice-gtk3-0.31

Description Joachim Frieben 2016-04-15 13:46:38 UTC
This bug was initially filed as https://bugzilla.redhat.com/show_bug.cgi?id=1266484

Description of problem:
When spice-vdagent is installed on the guest and you start a wayland session on the guest (or just use gdm which uses wayland by default) the screen flickers every second or so, because apparently spice-vdagent wants to resize the screen but the guest screen shize already has the desired size of the host window.

Version-Release number of selected component (if applicable):
0.16.0-1-fc23

How reproducible:
Always

Steps to Reproduce:
1. Install Fedora 22.
2. use Boxes to create a Fedora 23 Beta Workstation Guest using live iso.
3. Launch wayland session on guest.

Actual results:
Screen flickers and it's unusable until you remove spice-vdagent

Expected results:
Guest working fine
Comment 1 Joachim Frieben 2016-04-15 13:52:13 UTC
Created attachment 122969 [details] [review]
Patch for spice-gtk3-0.31

Issue applies also to the latest release spice-gtk-0.31. I have attached a sample patch for spice-gtk3 based on http://koji.fedoraproject.org/koji/taskinfo?taskID=13408204 which itself referred to http://lists.freedesktop.org/archives/spice-devel/2015-October/022730.html.
Comment 2 Pavel Grunt 2016-04-15 14:13:50 UTC
Hi, the issue is avoided upstream by the commit:
https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=ec6bfc00f81afddbdcc0fac86d7039385d89c6b6
Comment 3 Pavel Grunt 2016-05-02 20:41:22 UTC
Still not fixed
Comment 4 Joachim Frieben 2016-05-02 20:57:33 UTC
(In reply to Pavel Grunt from comment #3)
The attached patch -does- fix the issue in spice-gtk-0.31; also see

  https://bugzilla.redhat.com/show_bug.cgi?id=1330824 .

The problem is that your tentative Fedora 23 scratch build

  http://koji.fedoraproject.org/koji/taskinfo?taskID=13408204

-did- implement the equivalent (working) patch for spice-gtk-0.30 which, however, was -not- what you had implemented in the later regular Fedora errata.
Comment 5 Pavel Grunt 2016-05-03 06:52:16 UTC
(In reply to Joachim Frieben from comment #4)
> (In reply to Pavel Grunt from comment #3)
> The attached patch -does- fix the issue in spice-gtk-0.31; also see
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=1330824 .
> 
> The problem is that your tentative Fedora 23 scratch build
> 
>   http://koji.fedoraproject.org/koji/taskinfo?taskID=13408204
> 
> -did- implement the equivalent (working) patch for spice-gtk-0.30 which,
> however, was -not- what you had implemented in the later regular Fedora
> errata.

I still don't understand what wayland / mutter does differently, ie what causes the problem. So far I don't find anything wrong in spice-gtk.

There are several ways how to workaround it. Till the issue is there I recommend to use virt-viewer or remote-viewer for connecting to vms.
Comment 6 Joachim Frieben 2016-05-03 07:08:46 UTC
(In reply to Pavel Grunt from comment #5)
The original patch used for scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=13408204 worked well. Just use that one (or the equivalent above patch for spice-gtk(3)-0.31) and everybody will be happy; .. no need to look elsewhere! I have been successfully using a locally built and patched version of spice-gtk(3)-0.31 on my Fedora 24 box for weeks now.
Comment 7 Greg Fleury 2016-06-14 18:54:42 UTC
Note, I have seen the exact same thing on XFCE4 running spicy on x11-base/xorg-server-1.18.3

  When VDA-Agent starts up, I get a continuous flicker of the screen.
  This is almost like a screen refresh, where I am not even able to
  really click on things and/or open menus.

  Running Windows 10, x64

  app-emulation/spice-0.13.1-r2::gentoo
  net-misc/spice-gtk-0.31::gentoo
  app-emulation/spice-protocol-0.12.11::gentoo
  app-emulation/qemu--2.6.0::gentoo
  nvidia-drivers-367.18
  xorg-server-1.18.3

  Kernel string:

  Linux wks-ros 4.4.11 #6 SMP PREEMPT Mon May 30 00:01:35 MDT 2016
  x86_64 Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz GenuineIntel GNU/Linux


I ended up filing a bug under QEMU: 
https://bugs.launchpad.net/qemu/+bug/1592315
Comment 8 Joachim Frieben 2016-06-23 16:35:49 UTC
Issue is still present for the latest upstream release spice-gtk-0.32.
Comment 9 GitLab Migration User 2018-06-03 10:21:54 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/spice/spice-gtk/issues/33.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.