Bug 94977

Summary: pdftocairo: add -antialias option
Product: poppler Reporter: Adrian Johnson <ajohnson>
Component: utilsAssignee: poppler-bugs <poppler-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: medium CC: chris
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Add antialias option

Description Adrian Johnson 2016-04-17 06:40:06 UTC
Created attachment 123005 [details] [review]
Add antialias option

The attached patch adds an -antialias option to pdftocairo to allow setting the cairo antialias option for used for fonts and drawing.

I changed the blending into the page color code to use a push/pop group based on:

https://cgit.freedesktop.org/cairo/commit/test/pdf2png.c?id=f74b11415a1f7682dd50c222baa8815ef93681dc

However this does not seem to make any difference to the output when using "-antialias subpixel".
Comment 1 Carlos Garcia Campos 2016-04-18 13:07:06 UTC
Comment on attachment 123005 [details] [review]
Add antialias option

Review of attachment 123005 [details] [review]:
-----------------------------------------------------------------

Patch looks good to me.
Comment 2 Adrian Johnson 2016-05-20 09:55:47 UTC
Pushed
Comment 3 Adrian Johnson 2016-06-19 02:01:04 UTC
Carlos found some issues with this patch when running the regression tests. I've pushed out a couple of patches that revert the push/pop group and rename and fix an issue with the internal setAntialias().

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.