Bug 94993

Summary:	[BAT SKL] igt@kms_flip@basic-flip-vs-modeset: intel_atomic_commit: atomic_WARN(!lret) followed by vblank timeout
Product:	DRI	Reporter:	Imre Deak <imre.deak>
Component:	DRM/Intel	Assignee:	Intel GFX Bugs mailing list <intel-gfx-bugs>
Status:	CLOSED FIXED	QA Contact:	Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity:	blocker
Priority:	highest	CC:	intel-gfx-bugs
Version:	DRI git
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:	SKL	i915 features:	display/atomic

Description Imre Deak 2016-04-18 15:20:06 UTC

Excerpt from http://benchsrv.fi.intel.com//archive/results/CI_IGT_test/Patchwork_1927/skl-i7k-2/html/skl-i7k-2@Patchwork_1927@1/igt@kms_flip@basic-flip-vs-modeset.html:

"""
IGT-Version: 1.14-g7bd2ac6 (x86_64) (Linux: 4.6.0-rc4-CI-Patchwork_1927+ x86_64)
Using monotonic timestamps
Beginning basic-flip-vs-modeset on pipe A, connector HDMI-A-1
  1920x1080 60 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x48 148500

basic-flip-vs-modeset on pipe A, connector HDMI-A-1: PASSED

Beginning basic-flip-vs-modeset on pipe B, connector HDMI-A-1
  1920x1080 60 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x48 148500

basic-flip-vs-modeset on pipe B, connector HDMI-A-1: PASSED

Beginning basic-flip-vs-modeset on pipe C, connector HDMI-A-1
  1920x1080 60 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x48 148500

basic-flip-vs-modeset on pipe C, connector HDMI-A-1: PASSED

Subtest basic-flip-vs-modeset: SUCCESS (203.816s)
"""

dmesg:
"""
[  550.623934] ------------[ cut here ]------------
[  550.624013] WARNING: CPU: 3 PID: 6964 at drivers/gpu/drm/i915/intel_display.c:13529 intel_atomic_commit+0x1274/0x1400 [i915]
[  550.624018] WARN_ON(!lret)
[  550.624022] Modules linked in:
[  550.624027]  snd_hda_intel i915 snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul snd_hda_codec crc32_pclmul ghash_clmulni_intel snd_hwdep snd_hda_core snd_pcm mei_me mei i2c_hid e1000e ptp pps_core [last unloaded: i915]
[  550.624070] CPU: 3 PID: 6964 Comm: kms_flip Tainted: G     U  W       4.6.0-rc4-CI-Patchwork_1927+ #1
[  550.624075] Hardware name: System manufacturer System Product Name/Z170M-PLUS, BIOS 0701 01/13/2016
[  550.624079]  0000000000000000 ffff88022f03fb28 ffffffff81405e35 ffff88022f03fb78
[  550.624088]  0000000000000000 ffff88022f03fb68 ffffffff81079c7c 000034d931a45510
[  550.624095]  0000000000000001 ffff8800bc1ba2a8 0000000000000000 0000000000000000
[  550.624103] Call Trace:
[  550.624114]  [<ffffffff81405e35>] dump_stack+0x67/0x92
[  550.624122]  [<ffffffff81079c7c>] __warn+0xcc/0xf0
[  550.624128]  [<ffffffff81079cea>] warn_slowpath_fmt+0x4a/0x50
[  550.624137]  [<ffffffff810c2df9>] ? finish_wait+0x59/0x70
[  550.624198]  [<ffffffffa01ed324>] intel_atomic_commit+0x1274/0x1400 [i915]
[  550.624206]  [<ffffffff810c2f60>] ? wait_woken+0x90/0x90
[  550.624212]  [<ffffffff81538b52>] drm_atomic_commit+0x32/0x50
[  550.624220]  [<ffffffff8151565d>] drm_atomic_helper_set_config+0x7d/0xb0
[  550.624229]  [<ffffffff81528e40>] drm_mode_set_config_internal+0x60/0x110
[  550.624234]  [<ffffffff8152c616>] drm_mode_setcrtc+0x186/0x4f0
[  550.624239]  [<ffffffff8151e64d>] drm_ioctl+0x13d/0x590
[  550.624244]  [<ffffffff8152c490>] ? drm_mode_setplane+0x1b0/0x1b0
[  550.624253]  [<ffffffff811da623>] ? __vfs_read+0x23/0xd0
[  550.624258]  [<ffffffff811ee0aa>] do_vfs_ioctl+0x8a/0x670
[  550.624266]  [<ffffffff811f9f3a>] ? __fget_light+0x6a/0x90
[  550.624271]  [<ffffffff811ee6cc>] SyS_ioctl+0x3c/0x70
[  550.624286]  [<ffffffff817d24a9>] entry_SYSCALL_64_fastpath+0x1c/0xac
[  550.624291] ---[ end trace 42b35cb92446f3c6 ]---
[  610.695197] ------------[ cut here ]------------
[  610.695213] WARNING: CPU: 3 PID: 6964 at drivers/gpu/drm/drm_irq.c:1323 drm_wait_one_vblank+0x150/0x1a0
[  610.695218] vblank wait timed out on crtc 0
[  610.695221] Modules linked in: snd_hda_intel i915 snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul snd_hda_codec crc32_pclmul ghash_clmulni_intel snd_hwdep snd_hda_core snd_pcm mei_me mei i2c_hid e1000e ptp pps_core [last unloaded: i915]
[  610.695268] CPU: 3 PID: 6964 Comm: kms_flip Tainted: G     U  W       4.6.0-rc4-CI-Patchwork_1927+ #1
[  610.695272] Hardware name: System manufacturer System Product Name/Z170M-PLUS, BIOS 0701 01/13/2016
[  610.695276]  0000000000000000 ffff88022f03fa78 ffffffff81405e35 ffff88022f03fac8
[  610.695285]  0000000000000000 ffff88022f03fab8 ffffffff81079c7c 0000052b31a45510
[  610.695293]  ffff88022ec8c548 0000000000000000 0000000000003c00 ffff880231a45510
[  610.695302] Call Trace:
[  610.695311]  [<ffffffff81405e35>] dump_stack+0x67/0x92
[  610.695319]  [<ffffffff81079c7c>] __warn+0xcc/0xf0
[  610.695325]  [<ffffffff81079cea>] warn_slowpath_fmt+0x4a/0x50
[  610.695333]  [<ffffffff810c2df9>] ? finish_wait+0x59/0x70
[  610.695338]  [<ffffffff815206b0>] drm_wait_one_vblank+0x150/0x1a0
[  610.695345]  [<ffffffff810c2f60>] ? wait_woken+0x90/0x90
[  610.695417]  [<ffffffffa01ebb9d>] intel_pre_plane_update+0x15d/0x180 [i915]
[  610.695477]  [<ffffffffa01ec422>] intel_atomic_commit+0x372/0x1400 [i915]
[  610.695487]  [<ffffffff81537db9>] ? drm_atomic_get_crtc_state+0x29/0xc0
[  610.695494]  [<ffffffff810c2f60>] ? wait_woken+0x90/0x90
[  610.695499]  [<ffffffff81538b52>] drm_atomic_commit+0x32/0x50
[  610.695506]  [<ffffffff8151565d>] drm_atomic_helper_set_config+0x7d/0xb0
[  610.695514]  [<ffffffff81528e40>] drm_mode_set_config_internal+0x60/0x110
[  610.695519]  [<ffffffff8152c616>] drm_mode_setcrtc+0x186/0x4f0
[  610.695527]  [<ffffffff81195088>] ? __might_fault+0x48/0xa0
[  610.695532]  [<ffffffff8151e64d>] drm_ioctl+0x13d/0x590
[  610.695537]  [<ffffffff8152c490>] ? drm_mode_setplane+0x1b0/0x1b0
[  610.695545]  [<ffffffff811da623>] ? __vfs_read+0x23/0xd0
[  610.695550]  [<ffffffff811ee0aa>] do_vfs_ioctl+0x8a/0x670
[  610.695558]  [<ffffffff811f9f3a>] ? __fget_light+0x6a/0x90
[  610.695563]  [<ffffffff811ee6cc>] SyS_ioctl+0x3c/0x70
[  610.695571]  [<ffffffff817d24a9>] entry_SYSCALL_64_fastpath+0x1c/0xac
[  610.695577] ---[ end trace 42b35cb92446f3c7 ]---
"""

Comment 1 Imre Deak 2016-05-03 13:44:36 UTC

Possibly duplicate of bug 94572.

Comment 2 yann 2016-07-15 09:25:58 UTC

Updating priority accordingly: basic test failure

Comment 3 cprigent 2016-08-09 11:46:00 UTC

I don't reproduce it.
Test is success without such logs in kernel log.

Platform: NUC6i3SYB
CPU: Intel(R) Core(TM) i3-6100U CPU @ 2.30GHZ (family 6, model 78, stepping 3)
Motherboard version: H81132-502
GPU: Intel® HD Graphics 520 - Intel Corporation Sky Lake Integrated Graphics (rev 07)
Memory: one 8GB card Kingston KVR21S15D8/8
SSD: Samsung 850 EVO M.2 120 Go
Software
Bios: SYSKLi35.86A.0045.2016.0527.1055 from https://downloadcenter.intel.com/downloads/eula/26097/BIOS-Update-SYSKLi35-86A-?httpDown=https%3A%2F%2Fdownloadmirror.intel.com%2F26097%2Feng%2FSY0045.bio
Linux distribution: Ubuntu 16.04 64 bits
Kernel: 4.8.0-rc1 8ca71ca from http://cgit.freedesktop.org/drm-intel/
  commit 8ca71ca6198ad5a08a7d3e00f94149db2cdd5ebc
  Author: Daniel Vetter <daniel.vetter@ffwll.ch>
  Date:   Mon Aug 8 11:02:44 2016 +0200
  drm-intel-nightly: 2016y-08m-08d-09h-02m-24s UTC integration manifest
drm: libdrm-2.4.70-2 b214b05 from git://anongit.freedesktop.org/mesa/drm
mesa: mesa-11.2.2 3a9f628from git://anongit.freedesktop.org/mesa/mesa
cairo: 1.15.2 db8a7f1 from git://anongit.freedesktop.org/cairo
xserver: xorg-server-1.18.0-502 c833c08 from git://git.freedesktop.org/git/xorg/xserver
xf86-video-intel: 2.99.917-691 a77397a from git://git.freedesktop.org/git/xorg/driver/xf86-video-intel
libva: libva-1.7.0-44 695f99e from git://git.freedesktop.org/git/vaapi/libva
vaapi-intel-driver: 1.7.0-66 fb7d6f5 from git://git.freedesktop.org/git/vaapi/intel-driver
DMC 1.26 from https://01.org/sites/default/files/downloads/intelr-graphics-linux/skldmcver126.tar_1.bz2
GUC 6.1 from https://01.org/sites/default/files/downloads/intelr-graphics-linux/sklgucver61.tar.bz2
Intel-Gpu-Tools 1.15-216 9afd545 from http://anongit.freedesktop.org/git/xorg/app/intel-gpu-tools.git

Comment 4 Imre Deak 2016-08-09 12:13:31 UTC

Based on comment 3 closing this, assuming it's fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.