|Summary:||vkResetCommandPool should not destroy the command buffers.|
|Product:||Mesa||Reporter:||Ronie Salgado <roniesalg>|
|Component:||Drivers/Vulkan/intel||Assignee:||Jason Ekstrand <jason>|
|Status:||RESOLVED FIXED||QA Contact:||Intel 3D Bugs Mailing List <intel-3d-bugs>|
|i915 platform:||i915 features:|
|Attachments:||Bug workaround patch|
Description Ronie Salgado 2016-04-20 15:02:01 UTC
Created attachment 123092 [details] Bug workaround patch According to the Vulkan spec and a FIXME comment present in anv_ResetCommandPool (anv_cmd_buffer.c:~1100), vkResetCommandPool should not destroy the command buffers referenced by the command. The destruction of the command buffers breaks the samples of an open source abstraction layer above Vulkan that I am making. The abstraction layer along with the samples and build instructions are available at: https://github.com/ronsaldo/abstract-gpu current master whose commit number is 04255a7a93812d94d1b8683b13f67558c7b76e54 . The attached patch contains a quick workaround this problem that at least prevent the samples from crashing. The patch should be checked for potential memory leaks.
Comment 1 Jason Ekstrand 2016-05-24 05:16:49 UTC
Sorry for not getting back to this sooner. Somehow it missed my radar. You are correct that our implementation is invalid. The patch you attached isn't a workaround it is in fact the correct patch. Please send it to the mesa-dev mailing list and I'll make sure it gets reviewed and committed.