Bug 95138

Summary:	[deqp, 32bit, gen8+] deqp-gles31.functional.draw_indirect.negative
Product:	Mesa	Reporter:	Mark Janes <mark.a.janes>
Component:	Drivers/DRI/i965	Assignee:	Kenneth Graunke <kenneth>
Status:	RESOLVED FIXED	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	normal
Priority:	medium
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	94448

Description Mark Janes 2016-04-25 18:10:51 UTC

Two dEQP tests fail for 32bit platforms only:

deqp-gles31.functional.draw_indirect.negative.command_offset_not_in_buffer_signed32_wrap 
deqp-gles31.functional.draw_indirect.negative.command_offset_not_in_buffer_unsigned32_wrap

Sample output:

/tmp/build_root/m32/opt/deqp/modules/gles31/deqp-gles31 --deqp-case=dEQP-GLES31.functional.draw_indirect.negative.command_offset_not_in_buffer_signed32_wrap --deqp-log-images=disable --deqp-gl-config-name=rgba8888d24s8 --deqp-surface-width=400 --deqp-surface-height=300 --deqp-visibility=hidden
dEQP Core git-ac9895c3cd060bb4414b0a932e2d09b0c47dbef2 (0xac9895c3) starting..
  target implementation = 'X11 GLX'

Test case 'dEQP-GLES31.functional.draw_indirect.negative.command_offset_not_in_buffer_signed32_wrap'..
Test case duration in microseconds = 10749 us
  Fail (Got unexpected error.)

Comment 1 Kenneth Graunke 2016-04-26 06:52:29 UTC

Trivial integer overflow bug.  Should have a patch shortly.

Comment 2 Kenneth Graunke 2016-05-02 23:29:05 UTC

Fixed by:

commit 2655265fcba9017e793026c76e490e04db088c8f
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Mon Apr 25 22:34:37 2016 -0700

    mesa: Fix indirect draw buffer size check on 32-bit systems.
    
    Fixes dEQP-GLES31.functional subtests:
    draw_indirect.negative.command_offset_not_in_buffer_signed32_wrap
    draw_indirect.negative.command_offset_not_in_buffer_unsigned32_wrap
    
    These tests use really large values that overflow GLsizeiptr, at
    which point the buffer size isn't less than "end".
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95138
    Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
    Reviewed-by: Mark Janes <mark.a.janes@intel.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.