Bug 95227

Can you provide examples?

(In reply to Darxus from comment #1)
> Can you provide examples?

I'm not sure I follow this. What kind of examples do you need?

I've merely observed that there are some pieces of code that do something that you don't expect. Functions that take a file handle, but write their output to stdout, instead of making use of the provided file handle.

Filenames and line numbers that are doing this?

How to reproduce it?

(In reply to Darxus from comment #3)
> Filenames and line numbers that are doing this?

You can find those in the diff file:

src/cairo-debug.c:265
src/cairo-pattern.c:4610,4617
src/cairo-surface-observer.c:1222

> 
> How to reproduce it?

I did not check throughly, but I am pretty confident that the issue in the first file would only be visible when compiling cairo with TRACE-ing enabled (manually, in src/cairoint.h), that is unusual and only meant for debugging.

The bugs in src/cairo-pattern.c would not be visible without some significant changes, as all of the _cairo_debug_print_*pattern() functions are currently dead code. Again, they are meant as an aid when debugging cairo itself and are not (or at least should not be) exposed through the public API.

The last one looks like a genuine bug that can easily be triggered:

#include <cairo.h>

int
main (int argc, char *argv[])
{
    cairo_surface_t *image = cairo_image_surface_create (CAIRO_FORMAT_ARGB32, 32, 32);
    cairo_surface_t *surface = cairo_surface_create_observer (image, CAIRO_SURFACE_OBSERVER_NORMAL);

    cairo_surface_mark_dirty (surface);
    
    cairo_surface_destroy (surface);
    cairo_surface_destroy (image);

    return 0;
}

All of the changes look good to me (the first two in order to improve debugging, the last one as an actual bug fix). Only nit is I would also remove one of the two consecutive blank lines in the change for cairo-surface-observer.c ;)

If nobody raises concerns about the patch, I will merge it in the weekend.

Fixed in

commit a69e5af9cd62d1e8d9f503a9d74338a49e31f9cd
Author: Ed Schouten <ed@nuxi.nl>
Date:   Sun Sep 4 08:41:27 2016 +0200

    Write debugging information to the debugging file
    
    Some debugging functions wrote to stdout, which is inconsistent with
    the other debugging functions of the same groups.
    
    Instead they should write to the debugging file that they are given as
    input.
    
    Reviewed-by: Andrea Canciani <ranma42@gmail.com>
    
    Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=95227

commit efc40a94939a75c78474862638647bd5363d08cf
Author: Ed Schouten <ed@nuxi.nl>
Date:   Sun Sep 4 08:34:49 2016 +0200

    Prevent observer surfaces from writing to stdout
    
    Invoking cairo_surface_mark_dirty () on an observer surface would
    cause it to print debugging output to stdout.
    
    Reviewed-by: Andrea Canciani <ranma42@gmail.com>
    
    Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=95227