| Summary: | Possible memory leak in src/modules/module-filter-apply.c | ||
|---|---|---|---|
| Product: | PulseAudio | Reporter: | Sachin Kumar Chauhan <sachin.kc> |
| Component: | modules | Assignee: | pulseaudio-bugs |
| Status: | RESOLVED MOVED | QA Contact: | pulseaudio-bugs |
| Severity: | normal | ||
| Priority: | medium | CC: | lennart |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Hey Sachin, you're right. Looking at the code, you'll also notice that fltr is being leaked. Would you like to submit a fix for this? It might make sense to initialise fltr and module_name as NULL, and then just have something like:
if (something) {
pa_log(...);
goto done;
}
if (something else) {
pa_log(...);
goto done;
}
done:
pa_xfree(module_name);
pa_xfree(fltr);
return ...
This makes it more likely that we won't miss freeing if we add additional conditions.
OK. I will modify the code accordingly and submit a patch soon. Dear Arun, Patch has been sent to pulseaudio-discuss@lists.freedesktop.org I'll take a look shortly. You need to subscribe to the list to send mails to it, but I've cleared your mail manually for now. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/235. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
In below function, static pa_hook_result_t process(struct userdata *u, pa_object *o, bool is_sink_input); there seems a memory leak at Line No 452. if (should_group_filter(fltr) && !find_paired_master(u, fltr, o, is_sink_input)) { pa_log_debug("Want group filtering but don't have enough streams."); return PA_HOOK_OK; } It is returning without freeing memory allocated to module_name.