| Summary: | [IVB bisected] assert_scanout:531 assertion 'width == info.width && height == info.height' failed | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Chris Bainbridge <chris.bainbridge> | ||||||||||
| Component: | Driver/intel | Assignee: | Chris Wilson <chris> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||||
| Severity: | normal | ||||||||||||
| Priority: | medium | CC: | chris.bainbridge | ||||||||||
| Version: | git | ||||||||||||
| Hardware: | Other | ||||||||||||
| OS: | All | ||||||||||||
| Whiteboard: | |||||||||||||
| i915 platform: | i915 features: | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Chris Bainbridge
2016-05-14 13:42:53 UTC
Created attachment 123747 [details]
xorg-log-debugfull
btw looks like there is another issue after this one - I can't confirm it is completely independent until this issue is resolved but after reverting 46caee there are glitches which bisect to: 34bc024bf2c721f27cf17acbf8c46783d62f8d08 sna: Do not force ping-pong migration for TearFree + NoAccel I will attach a log anyway, though it seems more likely it is a different issue. Created attachment 123750 [details]
xorg-log-glitches
Log from current git with 46caee reverted, problems with 34bc02
I think I see the cause for the assertion failure, when switching from full-screen to single-crtc flipping - it ended up keeping the common untransformed TearFree buffer to reuse for the local transformed CRTC rendering. That should be fixed now.. The glitches I presume might be bug 95638? Created attachment 123784 [details] xorg-log-34f63f28c8f3 > That should be fixed now.. The assert still occurs with latest git (34f63f28c8f3). Log attached. > The glitches I presume might be bug 95638? Bug #95638 - Invalid bug number? Created attachment 123795 [details] [review] sna-Fix-assert_scanout-regression.patch The issue looks like a bug in the bisected commit (the "== 0" at end of drmIoctl line was missed), this patch reverts to the previous behaviour. With patch applied to latest git glitches still occur. Reverting "sna: Do not force ping-pong migration for TearFree + NoAccel" fixes it. (In reply to Chris Bainbridge from comment #6) > Created attachment 123795 [details] [review] [review] > sna-Fix-assert_scanout-regression.patch > > The issue looks like a bug in the bisected commit (the "== 0" at end of > drmIoctl line was missed), this patch reverts to the previous behaviour. I didn't even spot it when looking at the commit :( Thanks! The result would be that we didn't notice the modeset and used the old flip buffer (as the flips are reported after the change is in effect). commit ab3ab412a459a95e94707a4e39a18790ee04e6e3 Author: Chris Bainbridge <chris.bainbridge@gmail.com> Date: Tue May 17 07:26:10 2016 +0100 sna: Fix increment of modeset serial after applying CRTC We track how many mode sets have been made in order to detect stale flips (i.e. a sequence that crosses a mode change). This was broken by the logic inversion in setcrc in 46caee86db0f ("sna: Fix reporting of errno after setcrtc failure") References: https://bugs.freedesktop.org/show_bug.cgi?id=95401 Signed-off-by: Chris Bainbridge <chris.bainbridge@gmail.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> I meant bug 95368, but not this was a different issue. Please try: commit a508b11bde9f3119b49b3e0f652587efb9e037af Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Tue May 17 07:55:03 2016 +0100 sna: Don't skip migration-to-GPU for TearFree In 46caee86db0f ("sna: Fix reporting of errno after setcrtc failure"), the intention was to avoid reporting a fail to migrate whilst wedged for a simple copy from the frontbuffer to TearFree's shadow buffer. However, by skipping the migration, we never flushed any dirt from the CPU buffer prior to doing the TearFree flip. References: https://bugs.freedesktop.org/show_bug.cgi?id=95401#c7 References: https://bugs.freedesktop.org/show_bug.cgi?id=95414#c4 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Both issues now fixed. Thanks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.