Bug 95456

Summary:	glXGetFBConfigs has invalid screen bounds
Product:	Mesa	Reporter:	Jiri Slaby <jirislaby>
Component:	GLX	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:	mesa-dev
Severity:	normal
Priority:	medium	CC:	sndirsch
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch

Description Jiri Slaby 2016-05-17 14:30:21 UTC

Created attachment 123829 [details] [review]
patch

This is bad:
    if (priv && (priv->screens != NULL)
       && (screen >= 0) && (screen <= ScreenCount(dpy))
It should write:
    if (priv && (priv->screens != NULL)
       && (screen >= 0) && (screen < ScreenCount(dpy))


I have sent a patch to mesa-dev@lists.freedesktop.org, but it is moderated and I am not sure it went through.

Comment 1 Stefan Dirsch 2016-05-18 11:40:07 UTC

(In reply to Jiri Slaby from comment #0)
> Created attachment 123829 [details] [review] [review]
> patch
> 
> This is bad:
>     if (priv && (priv->screens != NULL)
>        && (screen >= 0) && (screen <= ScreenCount(dpy))
> It should write:
>     if (priv && (priv->screens != NULL)
>        && (screen >= 0) && (screen < ScreenCount(dpy))
> 
> 
> I have sent a patch to mesa-dev@lists.freedesktop.org, but it is moderated
> and I am not sure it went through.

It did. You even got a 'Reviewed-by' by ajax.

Comment 2 Emil Velikov 2016-05-23 12:04:34 UTC

Jiri, thanks for the patch. It's in master now and should be in -stable in a moment.

mesa-dev is moderated solely to prevent spam, if you want to avoid thing being stuck, please subscribe and disable email delivery if you prefer.

Stefan pretty sure Jiri got the reply in his inbox ;-)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.