Bug 95490

Summary: TabError: inconsistent use of tabs and spaces in indentation
Product: XCB Reporter: Tomasz Paweł Gajc <tpgxyz>
Component: LibraryAssignee: xcb mailing list dummy <xcb>
Status: RESOLVED FIXED QA Contact: xcb mailing list dummy <xcb>
Severity: critical    
Priority: medium    
Version: 1.12   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Tomasz Paweł Gajc 2016-05-19 13:53:25 UTC
Hi, i can't build libxcb-1.12 with LLVM/clang 3.8
i got error:

make[1]: Leaving directory '/builddir/build/BUILD/libxcb-1.12/src'
  File "./c_client.py", line 1937
    after_end_of_request = '(((char*)R) + R->length * 4)'
                                                        ^
TabError: inconsistent use of tabs and spaces in indentation
make[1]: *** [bigreq.c] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Entering directory '/builddir/build/BUILD/libxcb-1.12/src'
/usr/bin/python ./c_client.py	-c "libxcb 1.12" -l "X Version 11" \
	-s "3" -p /usr/lib/python3.4/site-packages \
	 \
	/usr/share/xcb/xproto.xml
Makefile:1289: recipe for target 'xproto.c' failed
make[1]: Leaving directory '/builddir/build/BUILD/libxcb-1.12/src'
  File "./c_client.py", line 1937
    after_end_of_request = '(((char*)R) + R->length * 4)'
                                                        ^
TabError: inconsistent use of tabs and spaces in indentation

More logs can be found here https://abf.openmandriva.org/build_lists/60538 in build.log file.
Comment 1 Rémi Cardona 2016-05-19 23:44:17 UTC
Your issue is IMHO 99.99% related to python 3. And a quick glance at that file confirms that the indentation is *not* python 3 compatible.

As I use python 3.4+ on a daily basis, I'll gladly review patches. If no one provides them, I may submit them on my own, but don't wait up on me.

Cheers
Comment 2 Thomas Klausner 2016-05-20 07:18:04 UTC
I provided patches for this and another problem for both xcb-proto and libxcb to the mailing list, see

https://lists.freedesktop.org/archives/xcb/2016-May/010759.html
https://lists.freedesktop.org/archives/xcb/2016-May/010758.html
https://lists.freedesktop.org/archives/xcb/2016-May/010760.html
Comment 3 Tomasz Paweł Gajc 2016-05-28 14:44:24 UTC
Yes, your patches are working fine.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.