Bug 95632

Summary: [BAT SKL] *ERROR* Potential atomic update failure on pipe A
Product: DRI Reporter: Tvrtko Ursulin <tvrtko.ursulin>
Component: DRM/IntelAssignee: Dhinakaran Pandiyan <dhinakaran.pandiyan>
Status: CLOSED DUPLICATE QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: critical    
Priority: highest CC: daniela.doras-prodan, intel-gfx-bugs, marius.c.vlad
Version: DRI git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: SKL i915 features: display/atomic
Attachments:
Description Flags
attachment-9442-0.html none

Description Tvrtko Ursulin 2016-05-24 10:28:23 UTC
Various IGTs are failing with this error. Example:

/archive/results/CI_IGT_test/RO_Patchwork_981/ro-skl-i7-6700hq/html/ro-skl-i7-6700hq@RO_Patchwork_981@1/igt@kms_frontbuffer_tracking@basic.html

Log:

[  346.138181] [drm:intel_pipe_update_start [i915]] *ERROR* Potential atomic update failure on pipe A
Comment 1 Daniel Vetter 2016-05-25 07:31:43 UTC
This seems to be a somewhat recent addition to our list of fail :( Seems to have started with RO_CI_DRM_435. Can someone from RO CI investigate/run a bisect please?
Comment 2 Marius Vlad 2016-05-25 15:48:22 UTC
@danvet: Ran BAT 3 times on on that machine (and two others), w/o triggering that err.

It looks like flip-flopping test to me.

From 435 to 438 kms_flip@basic-flip-vs-wf_vblank seems to trigger it more than once, but again can't reproduce.

Tried with:

commit fc9d741bc65b3eba8bdc51a668c202b39d81d833
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Wed May 25 09:46:14 2016 +0200

    drm-intel-nightly: 2016y-05m-25d-07h-45m-48s UTC integration manifest


(w/ Revert async unpin) commits. Wandering if it makes to go backwards (w/o that revert).
Comment 3 Marius Vlad 2016-05-25 16:01:03 UTC
Nope, I spoke too soon:

Managed to trigger it with:

$ kms_psr_sink_crc --run-subtest psr_basic
Comment 4 Ville Syrjala 2016-05-27 11:46:49 UTC
(In reply to Marius Vlad from comment #3)
> Nope, I spoke too soon:
> 
> Managed to trigger it with:
> 
> $ kms_psr_sink_crc --run-subtest psr_basic

Which might support my theory that we could be losing the vblank interrupt with PSR and/or DC5/6. Can you reproduce w/o DC5/6?
Comment 5 Marius Vlad 2016-06-07 13:14:20 UTC
I'm seeing a lot of messages likes this when running kms_flip test:

basic-flip-vs-wf_vblank

[  600.881610] DMAR: DRHD: handling fault status reg 3
[  600.881633] DMAR: [DMA Read] Request device [00:02.0] fault addr ff000000 [fault reason 06] PTE Read access is not set
Comment 6 Damien Grassart 2016-07-08 14:18:21 UTC
I am also seeing this error message on my i7-4500U laptop and was able to bisect it to this commit:

92dcc67c11d51671cca8df543e25c601e52336ad is the first bad commit
commit 92dcc67c11d51671cca8df543e25c601e52336ad
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Apr 28 09:56:46 2016 +0100

    drm/i915: Unify intel_ring_begin()
    
    Combine the near identical implementations of intel_logical_ring_begin()
    and intel_ring_begin() - the only difference is that the logical wait
    has to check for a matching ring (which is assumed by legacy).
    
    In the process some debug messages are culled as there were following a
    WARN if we hit an actual error.
    
    v2: Updated commentary
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
    Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/1461833819-3991-12-git-send-email-chris@chris-wilson.co.uk
    (cherry picked from commit 987046ad65361a8b038fbf8d76d152237fb7acf1)
    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Comment 7 Dhinakaran Pandiyan 2016-08-19 00:10:55 UTC
@Marius Vlad, is this error still seen in CI tests? I am not able to reproduce it on a SKL that I have.
Comment 8 Daniela Prodan 2016-08-19 00:11:27 UTC
Created attachment 125895 [details]
attachment-9442-0.html

Hello,

I am out of office and I will be back on August 24th. For anything urgent, please contact my manager Paul Parenteau.

Thank you,
Daniela
Comment 9 Damien Grassart 2016-08-22 02:06:58 UTC
I'm no longer seeing this error with 4.8.0-rc3 so this may have gotten fixed since then?
Comment 10 Dhinakaran Pandiyan 2016-08-25 21:33:22 UTC
@Damien Grassart
I was not able to reproduce the issue. So, I am not sure if a specific fix went in.


@Tvrtko Ursulin, should we just close this? The recent CI results do not show failures.
Comment 11 yann 2016-08-26 08:01:45 UTC
I confirm, this is not reproducible on any platforms in CI. therefore closing it.
Comment 12 Arcadiy Ivanov 2017-07-12 11:29:43 UTC
Fedora 26, kernel 4.11.9-300.fc26.x86_64

Kernel command line: BOOT_IMAGE=/vmlinuz-4.11.9-300.fc26.x86_64 root=/dev/mapper/fedora-root ro rd.lvm.lv=fedora/root rd.lvm.lv=fedora/swap rd.driver.blacklist=nouveau nouveau.modeset=0 rd.driver.blacklist=nouveau rd.driver.blacklist=psmouse i915.enable_guc_loading=1 i915.enable_guc_submission=1 intel_pstate=skylake_hwp i915.enable_psr=1 i915.disable_power_well=0 rhgb quiet

[    2.888511] [drm] Memory usable by graphics device = 4078M
[    2.888852] [drm] Replacing VGA console driver
[    2.895295] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
[    2.895297] [drm] Driver supports precise vblank timestamp query.
[    2.898397] [drm] Finished loading DMC firmware i915/skl_dmc_ver1_26.bin (v1.26)
[    2.934520] [drm] Initialized i915 1.6.0 20170123 for 0000:00:02.0 on minor 0
[    4.772712] [drm] RC6 on
[ 6590.721255] [drm] RC6 on
Comment 13 Arcadiy Ivanov 2017-07-12 11:30:12 UTC
[10277.337948] [drm:intel_pipe_update_start [i915]] *ERROR* Potential atomic update failure on pipe A
[10280.952927] [drm:intel_pipe_update_start [i915]] *ERROR* Potential atomic update failure on pipe A
[10287.635894] [drm:intel_pipe_update_start [i915]] *ERROR* Potential atomic update failure on pipe A
[10288.339881] [drm:intel_pipe_update_start [i915]] *ERROR* Potential atomic update failure on pipe A
[10292.338868] [drm:intel_pipe_update_start [i915]] *ERROR* Potential atomic update failure on pipe A
[10315.588806] [drm:intel_pipe_update_start [i915]] *ERROR* Potential atomic update failure on pipe A
Comment 14 Arcadiy Ivanov 2017-07-12 11:32:15 UTC
Base Board Information
        Manufacturer: Dell Inc.
        Product Name: 0M91XC
        Version: A00

BIOS Information
        Vendor: Dell Inc.
        Version: 1.12.4
        Release Date: 05/12/2017
        Address: 0xF0000
        Runtime Size: 64 kB
        ROM Size: 16 MB
Comment 15 Elizabeth 2017-07-27 16:25:22 UTC
Hello Arcadiy,
Could you please attach dmesg with drm.debug=0xe parameter on grub with latest kernel version on bug 91883 to follow up.
Thank you.

*** This bug has been marked as a duplicate of bug 91883 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.