Bug 9588

Summary: Removal of XFree86Server define broke nsc on non-Linux OS'es
Product: xorg Reporter: Alan Coopersmith <alan.coopersmith>
Component: Driver/nscAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: high    
Version: git   
Hardware: x86 (IA32)   
OS: Solaris   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 8888    
Attachments:
Description Flags
Corrections for broken nsc build
none
fix nsc driver by removing hal junk none

Description Alan Coopersmith 2007-01-09 19:16:44 UTC 
In xf86-video-nsc-2.8.2/src/durango.c definitions of gfx_msr_asm_read &
gfx_msr_asm_write are provided in the cases:

#if defined(OS_WIN32)                   /* For Windows */
#elif defined(OS_VXWORKS) || defined (OS_LINUX) /* VxWorks and Linux */
#elif defined(XFree86Server)

When XFree86Server is undefined, so is gfx_msr_asm_read, even though it's still
called, resulting in undefined symbol errors.

(Though I don't see OS_LINUX defined anywhere either, so it may be broken on
Linux too, but I didn't check.)
Comment 1 Daniel Stone 2007-01-09 23:12:39 UTC 
uh.  would you ever want to build that for non-XFree86Server?  shouldn't that
just be #ifdef WINNT, #elif (VXWORKS || linux), else?
Comment 2 Alan Coopersmith 2007-01-10 09:25:04 UTC 
It appears to have originally been a shared file with other projects/drivers for
other OS'es, so in that context the #ifdef might have made sense, but "why not
just remove it" was my initial thought too - just hoping someone who knew more 
about the code would know if it's still useful to allow builds of the code outside
the XF86Server context.
Comment 3 Daniel Stone 2007-02-27 01:35:34 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 4 Adam Jackson 2007-03-11 18:30:12 UTC 
The durango HAL in nsc is a complete trainwreck, don't feel bad at all about hacking it up to make it work again.
Comment 5 Markus Stockhausen 2007-08-01 10:04:10 UTC 
Created attachment 10940 [details]
Corrections for broken nsc build
Comment 6 Markus Stockhausen 2007-08-01 10:05:32 UTC 
I have applied a simple "#define XFree86Server 1" to all required files. If anyone wants to build this driver for non X environments just has to remove them.

Markus
Comment 7 Eric Anholt 2007-08-20 16:44:54 UTC 
Created attachment 11187 [details] [review]
fix nsc driver by removing hal junk

I've removed a bunch of the hal stuff, which may fix the issues.  Any objections, and could someone test it?
Comment 8 Eric Anholt 2007-09-04 18:12:53 UTC 
Feedback timeout, pushed changes and rolled a release.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.