Summary: | [BAT IVB] DMESG-WARN using smp_processor_id() in preemptible [00000000] code: usb-storage/216 | ||||||
---|---|---|---|---|---|---|---|
Product: | DRI | Reporter: | Sagar Kamble <sagar.a.kamble> | ||||
Component: | DRM/Intel | Assignee: | Sagar Kamble <sagar.a.kamble> | ||||
Status: | CLOSED WORKSFORME | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||
Severity: | critical | ||||||
Priority: | highest | CC: | intel-gfx-bugs | ||||
Version: | DRI git | ||||||
Hardware: | Other | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
i915 platform: | IVB | i915 features: | |||||
Attachments: |
|
Description
Sagar Kamble
2016-05-31 15:10:04 UTC
Created attachment 124216 [details] [review] Fix this_cpu_ptr() in intel/iommu Sagar, can you retest with Chris' patch and then update bug ? Applied to -nightly (+CI) via topic/core-for-CI: commit 46ad020cf7e398c3001bcfe45930003aa6fe62f0 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Wed Jun 1 12:10:08 2016 +0100 iommu: Disable preemption around use of this_cpu_ptr() Between acquiring the this_cpu_ptr() and using it, ideally we don't want to be preempted and work on another CPU's private data. this_cpu_ptr() checks whether or not preemption is disable, and get_cpu_ptr() provides a convenient wrapper for operating on the cpu ptr inside a preemption disabled critical section (which currently is provided by the spinlock). Indeed if we disable preemption around this_cpu_ptr, we do not need the CPU local spinlock - so long as take care that no other CPU is running that code as do perform the cross-CPU cache flushing and teardown, but that is a subject for another patch. Should quieten our CI testing. Results at /archive/results/CI_IGT_test/RO_Private_165/ ro-ivb2-i7-3770 total:102 pass:79 dwarn:0 dfail:0 fail:0 skip:22 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.