Bug 96383

Summary:	soup_session_async_new is deprecated
Product:	Wocky	Reporter:	diane
Component:	General	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	possible fix for soup_session_async_new

Description diane 2016-06-05 05:06:52 UTC

Created attachment 124325 [details]
possible fix for soup_session_async_new

I tried to build wocky & tests on a recent debian and it failed with an error that soup_session_async_new was deprecated.

I looked at
https://developer.gnome.org/libsoup/stable/libsoup-session-porting.html

and it seems like all I needed to do was to change to soup_session_new, the one call to soup_session provided a callback so I think its already async.

The other thing I did was put a version check in configure.ac to check for the version of libsoup that changed.

I suppose the other possibility is to conditionally compile to support both versions of libsoup.

Comment 1 George Kiagiadakis 2016-06-12 09:55:17 UTC

Looks good to me.
And libsoup 2.42 is 3 years old, so I see no reason to keep supporting earlier versions.

Comment 2 diane 2016-06-12 18:27:37 UTC

committed as ac4b6037dcba865dae03e3808173135402cdfd09

Comment 3 diane 2016-06-12 21:11:23 UTC

Comment on attachment 124325 [details]
possible fix for soup_session_async_new

commit ac4b6037dcba865dae03e3808173135402cdfd09

    soup_session_async_new is deprecated (Closes: #96383)
    
    * Replace with new call soup_session_new ();
    * Indicate minimum libsoup version

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.