| Summary: | [IVBGT1] piglit.spec.arb_compute_shader.linker.bug-93840 regression | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Mark Janes <mark.a.janes> |
| Component: | Drivers/DRI/i965 | Assignee: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | volodymyr.los |
| Version: | git | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Mark Janes
2016-06-13 04:46:30 UTC
Curro did mention that this would break. Apparently Ivybridge GT2 only requires SIMD16 for this test to work, while both GT1 and Baytrail require SIMD32, which spills more. Before this commit we would probably do something totally broken; I would imagine the test would be intermittent. (Maybe we were getting lucky...) We should probably implement the real solution. Should this test be fixed before the series is applied to 12.0? It passed reliably for the CI. We could also just skip backporting this patch to 12.0. As per Ken, the bisected commit adds assertions to detect a pre-existing issue. As such, it will not affect release builds and cannot be a regression. A fix has been sent to the list and can be backported after 12.0. (In reply to Mark Janes from comment #4) > As per Ken, the bisected commit adds assertions to detect a pre-existing > issue. As such, it will not affect release builds and cannot be a > regression. > > A fix has been sent to the list and can be backported after 12.0. I have no idea what patch that was (please include its name or URL). Was this bug actually solved? I don't see any references to this bug in git log. (In reply to Matt Turner from comment #5) > (In reply to Mark Janes from comment #4) > > As per Ken, the bisected commit adds assertions to detect a pre-existing > > issue. As such, it will not affect release builds and cannot be a > > regression. > > > > A fix has been sent to the list and can be backported after 12.0. > > I have no idea what patch that was (please include its name or URL). Was > this bug actually solved? I don't see any references to this bug in git log. It's this patch: https://lists.freedesktop.org/archives/mesa-stable/2016-June/004601.html also see v1 thread: https://lists.freedesktop.org/archives/mesa-stable/2016-June/004569.html IIRC I got some review feedback and dropped the ball. Feel free to pick it up. Mark, Is this actual for nowdays? $ /home/wlad/Work/piglit/piglit/bin/shader_runner /home/wlad/Work/piglit/piglit/tests/spec/arb_compute_shader/linker/bug-93840.shader_test -auto -fbo
PIGLIT: {"result": "pass" }
$ inxi -CGS
System: Host: wlad-dbg-pc Kernel: 4.14.30-1-MANJARO x86_64 bits: 64 Desktop: Cinnamon 3.6.6
Distro: Manjaro Linux 17.1.7 Hakoila
CPU: Topology: Quad Core model: Intel Core i5-3470 type: MCP L2 cache: 6144 KB
Speed: 1597 MHz min/max: 1600/3600 MHz Core speeds (MHz): 1: 1605 2: 1597 3: 1597 4: 1597
Graphics: Card-1: Intel Xeon E3-1200 v2/3rd Gen Core processor Graphics Controller driver: i915 v: kernel
Display Server: N/A driver: intel unloaded: fbdev,modesetting,vesa tty: 212x54
$ glxinfo | grep version
server glx version string: 1.4
client glx version string: 1.4
GLX version: 1.4
Max core profile version: 4.2
Max compat profile version: 3.0
Max GLES1 profile version: 1.1
Max GLES[23] profile version: 3.0
OpenGL core profile version string: 4.2 (Core Profile) Mesa 17.3.7
OpenGL core profile shading language version string: 4.20
OpenGL version string: 3.0 Mesa 17.3.7
OpenGL shading language version string: 1.30
OpenGL ES profile version string: OpenGL ES 3.0 Mesa 17.3.7
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.00
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.